r23507 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23506‎ | r23507 | r23508 >
Date:15:13, 28 June 2007
Author:brion
Status:old
Tags:
Comment:
* (bug 10396) Fix AJAX error when $wgScriptPath/index.php is not valid;
using $wgScript now included in JS info
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/common/ajax.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/ajax.js
@@ -75,7 +75,9 @@
7676 var i, x, n;
7777 var uri;
7878 var post_data;
79 - uri = wgServer + wgScriptPath + "/index.php?action=ajax";
 79+ uri = wgServer +
 80+ ((wgServer == null) ? (wgScriptPath + "/index.php") : wgScript) +
 81+ "?action=ajax";
8082 if (sajax_request_type == "GET") {
8183 if (uri.indexOf("?") == -1)
8284 uri = uri + "?rs=" + encodeURIComponent(func_name);
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1198,7 +1198,7 @@
11991199 * to ensure that client-side caches don't keep obsolete copies of global
12001200 * styles.
12011201 */
1202 -$wgStyleVersion = '77';
 1202+$wgStyleVersion = '78';
12031203
12041204
12051205 # Server-side caching:
Index: trunk/phase3/includes/Skin.php
@@ -293,7 +293,7 @@
294294 * The odd calling convention is for backwards compatibility
295295 */
296296 static function makeGlobalVariablesScript( $data ) {
297 - global $wgStylePath, $wgUser;
 297+ global $wgScript, $wgStylePath, $wgUser;
298298 global $wgArticlePath, $wgScriptPath, $wgServer, $wgContLang, $wgLang;
299299 global $wgTitle, $wgCanonicalNamespaceNames, $wgOut, $wgArticle;
300300 global $wgBreakFrames, $wgRequest;
@@ -306,6 +306,7 @@
307307 'stylepath' => $wgStylePath,
308308 'wgArticlePath' => $wgArticlePath,
309309 'wgScriptPath' => $wgScriptPath,
 310+ 'wgScript' => $wgScript,
310311 'wgServer' => $wgServer,
311312 'wgCanonicalNamespace' => $nsname,
312313 'wgCanonicalSpecialPageName' => SpecialPage::resolveAlias( $wgTitle->getDBKey() ),
Index: trunk/phase3/RELEASE-NOTES
@@ -224,6 +224,8 @@
225225 * (bug 7071) Properly handle an 'oldid' passed to view or edit that doesn't
226226 match the given title. Fixes inconsistencies with talk, history, edit links.
227227 * (bug 10397) Fix AJAX watch error fallback when we receive a bogus result
 228+* (bug 10396) Fix AJAX error when $wgScriptPath/index.php is not valid;
 229+ using $wgScript now included in JS info
228230
229231
230232 == API changes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r23581Merged revisions 23406-23580 via svnmerge from...david04:50, 30 June 2007

Status & tagging log