r23494 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23493‎ | r23494 | r23495 >
Date:21:02, 27 June 2007
Author:brion
Status:old
Tags:
Comment:
Revert r23034 for the moment; made it hard to clearly extract log line information via cut-n-paste since date is missing
Modified paths:
  • /trunk/phase3/includes/SpecialLog.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialLog.php
@@ -322,25 +322,13 @@
323323 }
324324
325325 function doShowList( &$out, $result ) {
326 - global $wgLang;
327 -
328 - $lastdate = '';
329 - $listopen = false;
330326 // Rewind result pointer and go through it again, making the HTML
331 - $html = '';
 327+ $html = "\n<ul>\n";
332328 $result->seek( 0 );
333329 while( $s = $result->fetchObject() ) {
334 - $date = $wgLang->date( $s->log_timestamp, /* adj */ true );
335 - if ( $date != $lastdate ) {
336 - if ( $listopen ) { $html .= Xml::closeElement( 'ul' ); }
337 - $html .= Xml::element('h4', null, $date) . "\n";
338 - $html .= Xml::openElement( 'ul' );
339 - $listopen = true;
340 - $lastdate = $date;
341 - }
342 - $html .= Xml::tags('li', null, $this->logLine( $s ) ) . "\n";
 330+ $html .= $this->logLine( $s );
343331 }
344 - if ( $listopen ) { $html .= Xml::closeElement( 'ul' ); }
 332+ $html .= "\n</ul>\n";
345333 $out->addHTML( $html );
346334 $result->free();
347335 }
@@ -358,7 +346,7 @@
359347 global $wgLang, $wgUser;;
360348 $skin = $wgUser->getSkin();
361349 $title = Title::makeTitle( $s->log_namespace, $s->log_title );
362 - $time = $wgLang->time( wfTimestamp(TS_MW, $s->log_timestamp), true );
 350+ $time = $wgLang->timeanddate( wfTimestamp(TS_MW, $s->log_timestamp), true );
363351
364352 // Enter the existence or non-existence of this page into the link cache,
365353 // for faster makeLinkObj() in LogPage::actionText()
@@ -412,7 +400,7 @@
413401 }
414402
415403 $action = LogPage::actionText( $s->log_type, $s->log_action, $title, $this->skin, $paramArray, true, true );
416 - $out = "$time $userLink $action $comment $revert";
 404+ $out = "<li>$time $userLink $action $comment $revert</li>\n";
417405 return $out;
418406 }
419407

Follow-up revisions

RevisionCommit summaryAuthorDate
r23581Merged revisions 23406-23580 via svnmerge from...david04:50, 30 June 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r23034* Group log output by date...nikerabbit16:45, 16 June 2007

Status & tagging log