r23448 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23447‎ | r23448 | r23449 >
Date:02:49, 27 June 2007
Author:robchurch
Status:old
Tags:
Comment:
Use Linker::makeKnownLinkObj(); we have a Title object, and it's faster
Modified paths:
  • /trunk/phase3/includes/SpecialLog.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialLog.php
@@ -397,9 +397,7 @@
398398 'action=unblock&ip=' . urlencode( $s->log_title ) ) . ')';
399399 // show change protection link
400400 } elseif ( ( $s->log_action == 'protect' || $s->log_action == 'modify' ) && $wgUser->isAllowed( 'protect' ) ) {
401 - $revert = '(' . $skin->makeKnownLink( $title->getPrefixedDBkey() ,
402 - wfMsg( 'protect_change' ),
403 - 'action=unprotect' ) . ')';
 401+ $revert = '(' . $skin->makeKnownLinkObj( $title, wfMsg( 'protect_change' ), 'action=unprotect' ) . ')';
404402 // show user tool links for self created users
405403 // TODO: The extension should be handling this, get it out of core!
406404 } elseif ( $s->log_action == 'create2' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r23581Merged revisions 23406-23580 via svnmerge from...david04:50, 30 June 2007

Status & tagging log