r23339 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23338‎ | r23339 | r23340 >
Date:22:34, 24 June 2007
Author:simetrical
Status:old
Tags:
Comment:
(bug 9250) Remove hardcoded minimum image name length of three characters. Message minlength renamed to minlength1.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialUpload.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHe.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialUpload.php
@@ -308,8 +308,8 @@
309309 $partname .= '.' . $ext[$i];
310310 }
311311
312 - if( strlen( $partname ) < 3 ) {
313 - $this->mainUploadForm( wfMsgHtml( 'minlength' ) );
 312+ if( strlen( $partname ) < 1 ) {
 313+ $this->mainUploadForm( wfMsgHtml( 'minlength1' ) );
314314 return;
315315 }
316316
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1361,7 +1361,7 @@
13621362 'uploadedfiles' => 'Uploaded files',
13631363 'ignorewarning' => 'Ignore warning and save file anyway.',
13641364 'ignorewarnings' => 'Ignore any warnings',
1365 -'minlength' => 'File names must be at least three letters.',
 1365+'minlength1' => 'File names must be at least one letter.',
13661366 'illegalfilename' => 'The filename "$1" contains characters that are not allowed in page titles. Please rename the file and try uploading it again.',
13671367 'badfilename' => 'File name has been changed to "$1".',
13681368 'filetype-badmime' => 'Files of the MIME type "$1" are not allowed to be uploaded.',
Index: trunk/phase3/languages/messages/MessagesHe.php
@@ -1025,7 +1025,7 @@
10261026 'uploadedfiles' => 'קבצים שהועלו',
10271027 'ignorewarning' => 'התעלם מהאזהרה ושמור את הקובץ בכל זאת.',
10281028 'ignorewarnings' => 'התעלם מכל האזהרות',
1029 -'minlength' => 'שמות של קבצי תמונה צריכים להיות בני שלושה תווים לפחות.',
 1029+'minlength1' => 'שמות של קבצי תמונה צריכים להיות בני תו אחד לפחות.',
10301030 'illegalfilename' => 'הקובץ "$1" מכיל תוים בלתי חוקיים. אנא שנו את שמו ונסו להעלותו שנית.',
10311031 'badfilename' => 'שם התמונה שונה ל־"$1".',
10321032 'filetype-badmime' => 'לא ניתן להעלות קבצים עם סוג ה־MIME "$1".',
Index: trunk/phase3/RELEASE-NOTES
@@ -100,6 +100,7 @@
101101 * (bug 10326) AJAX-based page watching and unwatching has been cleaned up and
102102 enabled by default.
103103 * Added option to install to MyISAM
 104+* (bug 9250) Remove hardcoded minimum image name length of three characters
104105
105106 == Bugfixes since 1.10 ==
106107

Follow-up revisions

RevisionCommit summaryAuthorDate
r23407Merged revisions 23203-23405 via svnmerge from...david23:00, 25 June 2007

Status & tagging log