r23331 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23330‎ | r23331 | r23332 >
Date:18:38, 24 June 2007
Author:aaron
Status:old
Tags:
Comment:
*Clean up tags for users with JS disabled
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevsPage.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -96,7 +96,7 @@
9797 // For users of the monobook skin, a simplified UI will be used.
9898 // Ratings will go by the toolbox. The standard UI still shows
9999 // in edit mode and at stable versions.
100 -$wgSimpleFlaggedRevsUI = true;
 100+$wgSimpleFlaggedRevsUI = false;
101101
102102 # Lets some users access the review UI and set some flags
103103 $wgAvailableRights[] = 'review';
@@ -911,9 +911,8 @@
912912 # Hide clutter
913913 $tag .= ' <a id="mwrevisiontoggle" style="display:none;" href="javascript:toggleRevRatings()">' .
914914 wfMsg('revreview-toggle') . '</a>';
915 - $tag .= '<span id="mwrevisionratings">' .
916 - wfMsg('revreview-oldrating') . parent::addTagRatings( $flags ) .
917 - '</span>';
 915+ $tag .= '<span id="mwrevisionratings" style="display:block;">' .
 916+ wfMsg('revreview-oldrating') . parent::addTagRatings( $flags ) . '</span>';
918917 }
919918 }
920919 # Viewing the page normally: override the page
@@ -932,9 +931,8 @@
933932 $tag = wfMsgExt($msg, array('parseinline'), $vis_id, $time, $revs_since);
934933 $tag .= ' <a id="mwrevisiontoggle" style="display:none;" href="javascript:toggleRevRatings()">' .
935934 wfMsg('revreview-toggle') . '</a>';
936 - $tag .= '<span id="mwrevisionratings">' .
937 - parent::addTagRatings( $flags ) .
938 - '</span>';
 935+ $tag .= '<span id="mwrevisionratings" style="display:block;">' .
 936+ parent::addTagRatings( $flags ) . '</span>';
939937 }
940938 }
941939 # Try the stable page cache
@@ -1009,7 +1007,7 @@
10101008 $tag = wfMsgExt($msg, array('parseinline'), $tfrev->fr_rev_id, $time, $revs_since );
10111009 # Hide clutter
10121010 $tag .= ' <a id="mwrevisiontoggle" style="display:none;" href="javascript:toggleRevRatings()">' . wfMsg('revreview-toggle') . '</a>';
1013 - $tag .= '<span id="mwrevisionratings">' .
 1011+ $tag .= '<span id="mwrevisionratings" style="display:block;">' .
10141012 wfMsg('revreview-oldrating') . parent::addTagRatings( $flags ) .
10151013 '</span>';
10161014 $wgOut->addHTML( '<div id="mwrevisiontag" class="flaggedrevs_notice plainlinks">' . $tag . '</div><br/>' );
Index: trunk/extensions/FlaggedRevs/FlaggedRevsPage.body.php
@@ -550,8 +550,11 @@
551551 $flags = FlaggedRevs::getFlagsForPageRev( $frev->fr_rev_id );
552552 $time = $wgLang->timeanddate( wfTimestamp(TS_MW, $frev->fr_timestamp), true );
553553 // We will be looking at the reviewed revision...
554 - $tag = wfMsgExt('revreview-static', array('parse'), urlencode($page->getPrefixedText()), $time, $page->getPrefixedText());
555 - $tag .= $RevFlagging->addTagRatings( $flags );
 554+ $tag = wfMsgExt('revreview-static', array('parseinline'), urlencode($page->getPrefixedText()), $time, $page->getPrefixedText());
 555+ $tag .= ' <a id="mwrevisiontoggle" style="display:none;" href="javascript:toggleRevRatings()">' . wfMsg('revreview-toggle') . '</a>';
 556+ $tag .= '<span id="mwrevisionratings" style="display:block;">' .
 557+ wfMsg('revreview-oldrating') . $RevFlagging->addTagRatings( $flags ) .
 558+ '</span>';
556559 // Parse the text...
557560 $text = $RevFlagging->getFlaggedRevText( $this->oldid );
558561 $options = ParserOptions::newFromUser($wgUser);

Status & tagging log