r23314 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23313‎ | r23314 | r23315 >
Date:06:35, 24 June 2007
Author:aaron
Status:old
Tags:
Comment:
*Some fixes
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -93,8 +93,9 @@
9494 'style' => array('review' => 3),
9595 );
9696
97 -// For users of the monobook skin, a simplified UI
98 -// will be used. Ratings will go by the toolbox.
 97+// For users of the monobook skin, a simplified UI will be used.
 98+// Ratings will go by the toolbox. The standard UI still shows
 99+// in edit mode and at stable versions.
99100 $wgSimpleFlaggedRevsUI = true;
100101
101102 # Lets some users access the review UI and set some flags
@@ -844,10 +845,10 @@
845846 $tagClass = 'flaggedrevs_box1';
846847 // Construct some tagging
847848 if( !$wgOut->isPrintable() ) {
848 - $msg = $quality ? 'revreview-newest-quality' : 'revreview-newest-basic';
 849+ $msg = $quality ? 'revreview-quality' : 'revreview-basic';
849850 $box = parent::addTagRatings( $flags, true, "{$tagClass}a" );
850 - $box .= '<h5><a href="javascript:toggleRevRatings()">' . wfMsg('revreview-toggle') . '</a></h5>';
851 - $box .= '<span id="mwrevisionratings" style="display:none">' .
 851+ $box .= '<h5><a id="mwrevisiontoggle" style="display:none;" href="javascript:toggleRevRatings()">' . wfMsg('revreview-toggle') . '</a></h5>';
 852+ $box .= '<span id="mwrevisionratings">' .
852853 wfMsgExt($msg, array('parseinline'), $vis_id, $time, $revs_since) .
853854 '</span>';
854855 }
@@ -908,9 +909,9 @@
909910 $msg = $quality ? 'revreview-newest-quality' : 'revreview-newest-basic';
910911 $tag .= wfMsgExt($msg, array('parseinline'), $tfrev->fr_rev_id, $time, $revs_since);
911912 # Hide clutter
912 - $tag .= ' <a id="mwrevisiontoggle" style="display: none;" href="javascript:toggleRevRatings()">' .
 913+ $tag .= ' <a id="mwrevisiontoggle" style="display:none;" href="javascript:toggleRevRatings()">' .
913914 wfMsg('revreview-toggle') . '</a>';
914 - $tag .= '<span id="mwrevisionratings" style="display:none">' .
 915+ $tag .= '<span id="mwrevisionratings">' .
915916 wfMsg('revreview-oldrating') . parent::addTagRatings( $flags ) .
916917 '</span>';
917918 }
@@ -928,9 +929,9 @@
929930 } else {
930931 $msg = $quality ? 'revreview-quality' : 'revreview-basic';
931932 $tag = wfMsgExt($msg, array('parseinline'), $vis_id, $time, $revs_since);
932 - $tag .= ' <a id="mwrevisiontoggle" style="display: none;" href="javascript:toggleRevRatings()">' .
 933+ $tag .= ' <a id="mwrevisiontoggle" style="display:none;" href="javascript:toggleRevRatings()">' .
933934 wfMsg('revreview-toggle') . '</a>';
934 - $tag .= '<span id="mwrevisionratings" style="display:none">' .
 935+ $tag .= '<span id="mwrevisionratings">' .
935936 parent::addTagRatings( $flags ) .
936937 '</span>';
937938 }
@@ -1006,8 +1007,8 @@
10071008 $msg = $this->isQuality( $flags ) ? 'revreview-newest-quality' : 'revreview-newest-basic';
10081009 $tag = wfMsgExt($msg, array('parseinline'), $tfrev->fr_rev_id, $time, $revs_since );
10091010 # Hide clutter
1010 - $tag .= ' <a href="javascript:toggleRevRatings()">' . wfMsg('revreview-toggle') . '</a>';
1011 - $tag .= '<span id="mwrevisionratings" style="display:none">' .
 1011+ $tag .= ' <a id="mwrevisiontoggle" style="display:none;" href="javascript:toggleRevRatings()">' . wfMsg('revreview-toggle') . '</a>';
 1012+ $tag .= '<span id="mwrevisionratings">' .
10121013 wfMsg('revreview-oldrating') . parent::addTagRatings( $flags ) .
10131014 '</span>';
10141015 $wgOut->addHTML( '<div id="mwrevisiontag" class="flaggedrevs_notice plainlinks">' . $tag . '</div><br/>' );

Status & tagging log