r23282 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r23281‎ | r23282 | r23283 >
Date:04:45, 23 June 2007
Author:robchurch
Status:old
Tags:
Comment:
Ditch obsolete `querycache`, `querycachetwo` and `querycache_info` tables
Modified paths:
  • /branches/robchurch/reports/maintenance/archives/patch-querycache.sql (deleted) (history)
  • /branches/robchurch/reports/maintenance/archives/patch-querycacheinfo.sql (deleted) (history)
  • /branches/robchurch/reports/maintenance/archives/patch-querycachetwo.sql (deleted) (history)
  • /branches/robchurch/reports/maintenance/tables.sql (modified) (history)
  • /branches/robchurch/reports/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: branches/robchurch/reports/maintenance/archives/patch-querycacheinfo.sql
——@@ -1,12 +0,0 @@
2 -CREATE TABLE /*$wgDBprefix*/querycache_info (
3 -
4 - -- Special page name
5 - -- Corresponds to a qc_type value
6 - qci_type varbinary(32) NOT NULL default '',
7 -
8 - -- Timestamp of last update
9 - qci_timestamp binary(14) NOT NULL default '19700101000000',
10 -
11 - UNIQUE KEY ( qci_type )
12 -
13 -) /*$wgDBTableOptions*/;
Index: branches/robchurch/reports/maintenance/archives/patch-querycachetwo.sql
——@@ -1,22 +0,0 @@
2 -
3 -CREATE TABLE /*$wgDBprefix*/querycachetwo (
4 - -- A key name, generally the base name of of the special page.
5 - qcc_type varbinary(32) NOT NULL,
6 -
7 - -- Some sort of stored value. Sizes, counts...
8 - qcc_value int unsigned NOT NULL default '0',
9 -
10 - -- Target namespace+title
11 - qcc_namespace int NOT NULL default '0',
12 - qcc_title varchar(255) binary NOT NULL default '',
13 -
14 - -- Target namespace+title2
15 - qcc_namespacetwo int NOT NULL default '0',
16 - qcc_titletwo varchar(255) binary NOT NULL default '',
17 -
18 - KEY qcc_type (qcc_type,qcc_value),
19 - KEY qcc_title (qcc_type,qcc_namespace,qcc_title),
20 - KEY qcc_titletwo (qcc_type,qcc_namespacetwo,qcc_titletwo)
21 -
22 -) /*$wgDBTableOptions*/;
Index: branches/robchurch/reports/maintenance/archives/patch-querycache.sql
——@@ -1,16 +0,0 @@
2 -
3 -CREATE TABLE /*$wgDBprefix*/querycache (
4 - -- A key name, generally the base name of of the special page.
5 - qc_type varbinary(32) NOT NULL,
6 -
7 - -- Some sort of stored value. Sizes, counts...
8 - qc_value int unsigned NOT NULL default '0',
9 -
10 - -- Target namespace+title
11 - qc_namespace int NOT NULL default '0',
12 - qc_title varchar(255) binary NOT NULL default '',
13 -
14 - KEY (qc_type,qc_value)
15 -
16 -) /*$wgDBTableOptions*/;
Index: branches/robchurch/reports/maintenance/updaters.inc
——@@ -22,7 +22,6 @@
2323 $wgNewTables = array(
2424 # table patch file (in maintenance/archives)
2525 array( 'hitcounter', 'patch-hitcounter.sql' ),
26 - array( 'querycache', 'patch-querycache.sql' ),
2726 array( 'objectcache', 'patch-objectcache.sql' ),
2827 array( 'categorylinks', 'patch-categorylinks.sql' ),
2928 array( 'logging', 'patch-logging.sql' ),
——@@ -32,9 +31,7 @@
3332 array( 'externallinks', 'patch-externallinks.sql' ),
3433 array( 'job', 'patch-job.sql' ),
3534 array( 'langlinks', 'patch-langlinks.sql' ),
36 - array( 'querycache_info', 'patch-querycacheinfo.sql' ),
3735 array( 'filearchive', 'patch-filearchive.sql' ),
38 - array( 'querycachetwo', 'patch-querycachetwo.sql' ),
3936 array( 'reportcache', 'patch-reportcache.sql' ),
4037 array( 'reportcache_info', 'patch-reportcache_info.sql' ),
4138 );
Index: branches/robchurch/reports/maintenance/tables.sql
——@@ -961,24 +961,6 @@
962962 ) /*$wgDBTableOptions*/;
963963
964964 --
965 -CREATE TABLE /*$wgDBprefix*/querycache (
966 - -- A key name, generally the base name of of the special page.
967 - qc_type varbinary(32) NOT NULL,
968 -
969 - -- Some sort of stored value. Sizes, counts...
970 - qc_value int unsigned NOT NULL default '0',
971 -
972 - -- Target namespace+title
973 - qc_namespace int NOT NULL default '0',
974 - qc_title varchar(255) binary NOT NULL default '',
975 -
976 - KEY (qc_type,qc_value)
977 -
978 -) /*$wgDBTableOptions*/;
979 -
980965 -- For a few generic cache operations if not using Memcached
981966 --
982967 CREATE TABLE /*$wgDBprefix*/objectcache (
——@@ -1073,20 +1055,6 @@
10741056 ) /*$wgDBTableOptions*/;
10751057
10761058
1077 -CREATE TABLE /*$wgDBprefix*/querycache_info (
1078 -
1079 - -- Special page name
1080 - -- Corresponds to a qc_type value
1081 - qci_type varbinary(32) NOT NULL default '',
1082 -
1083 - -- Timestamp of last update
1084 - qci_timestamp binary(14) NOT NULL default '19700101000000',
1085 -
1086 - UNIQUE KEY ( qci_type )
1087 -
1088 -) /*$wgDBTableOptions*/;
1089 -
10901059 -- For each redirect, this table contains exactly one row defining its target
10911060 CREATE TABLE /*$wgDBprefix*/redirect (
10921061 -- Key to the page_id of the redirect page
——@@ -1103,28 +1071,6 @@
11041072 KEY rd_ns_title (rd_namespace,rd_title,rd_from)
11051073 ) /*$wgDBTableOptions*/;
11061074
1107 -CREATE TABLE /*$wgDBprefix*/querycachetwo (
1108 - -- A key name, generally the base name of of the special page.
1109 - qcc_type varbinary(32) NOT NULL,
1110 -
1111 - -- Some sort of stored value. Sizes, counts...
1112 - qcc_value int unsigned NOT NULL default '0',
1113 -
1114 - -- Target namespace+title
1115 - qcc_namespace int NOT NULL default '0',
1116 - qcc_title varchar(255) binary NOT NULL default '',
1117 -
1118 - -- Target namespace+title2
1119 - qcc_namespacetwo int NOT NULL default '0',
1120 - qcc_titletwo varchar(255) binary NOT NULL default '',
1121 -
1122 - KEY qcc_type (qcc_type,qcc_value),
1123 - KEY qcc_title (qcc_type,qcc_namespace,qcc_title),
1124 - KEY qcc_titletwo (qcc_type,qcc_namespacetwo,qcc_titletwo)
1125 -
1126 -) /*$wgDBTableOptions*/;
1127 -
11281075 -- Used for storing page restrictions (i.e. protection levels)
11291076 CREATE TABLE /*$wgDBprefix*/page_restrictions (
11301077 -- Page to apply restrictions to (Foreign Key to page).

Status & tagging log