r23257 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23256‎ | r23257 | r23258 >
Date:22:00, 22 June 2007
Author:greg
Status:old
Tags:
Comment:
getLag() returns false, not 0. Add reminder about future code refactoring.
Modified paths:
  • /trunk/phase3/includes/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DatabasePostgres.php
@@ -155,6 +155,7 @@
156156
157157 $this->mOpened = true;
158158 ## If this is the initial connection, setup the schema stuff and possibly create the user
 159+ ## TODO: Move this out of open()
159160 if (defined('MEDIAWIKI_INSTALL')) {
160161 global $wgDBname, $wgDBuser, $wgDBpassword, $wgDBsuperuser, $wgDBmwschema,
161162 $wgDBts2schema;
@@ -1177,11 +1178,10 @@
11781179 /**
11791180 * How lagged is this slave?
11801181 *
1181 - * @return int
11821182 */
11831183 public function getLag() {
11841184 # Not implemented for PostgreSQL
1185 - return 0;
 1185+ return false;
11861186 }
11871187
11881188 } // end DatabasePostgres class

Follow-up revisions

RevisionCommit summaryAuthorDate
r23407Merged revisions 23203-23405 via svnmerge from...david23:00, 25 June 2007

Status & tagging log