r23101 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23100‎ | r23101 | r23102 >
Date:16:00, 19 June 2007
Author:brion
Status:old
Tags:
Comment:
* (bug 10309) Initialise parser state properly in extractSections(), fixes
some cases where section edits broke because tags were improperly stripped
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser.php
@@ -4609,6 +4609,10 @@
46104610 * for "replace", the whole page with the section replaced.
46114611 */
46124612 private function extractSections( $text, $section, $mode, $newtext='' ) {
 4613+ # I.... _hope_ this is right.
 4614+ # Otherwise, sometimes we don't have things initialized properly.
 4615+ $this->clearState();
 4616+
46134617 # strip NOWIKI etc. to avoid confusion (true-parameter causes HTML
46144618 # comments to be stripped as well)
46154619 $stripState = new StripState;
Index: trunk/phase3/RELEASE-NOTES
@@ -177,7 +177,10 @@
178178 Signature dates for Japanese and other languages including weekday now show
179179 the correct day to match the rest of the time in local time.
180180 * Escape the output of magic variables that return page name or part of it
 181+* (bug 10309) Initialise parser state properly in extractSections(), fixes
 182+ some cases where section edits broke because tags were improperly stripped
181183
 184+
182185 == API changes since 1.10 ==
183186
184187 (For ongoing development discussion, see http://www.mediawiki.org/wiki/API)

Follow-up revisions

RevisionCommit summaryAuthorDate
r23104Merged revisions 23087-23102 via svnmerge from...david21:40, 19 June 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r23100parser test cases for bug 10309brion15:49, 19 June 2007

Status & tagging log