r23097 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23096‎ | r23097 | r23098 >
Date:14:42, 19 June 2007
Author:robchurch
Status:old
Tags:
Comment:
Our release manager believes I need to be shot. I am a mindless drone without opinion in this matter.
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)
  • /trunk/phase3/includes/SpecialWithoutinterwiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -320,7 +320,7 @@
321321 function buildExpiryInput() {
322322 $attribs = array( 'id' => 'expires' ) + $this->disabledAttrib;
323323 return '<tr>'
324 - . '<td><label for="expires">' . wfMsgWithLinks( 'protectexpiry' ) . '</label></td>'
 324+ . '<td><label for="expires">' . wfMsgExt( 'protectexpiry', array( 'parseinline' ) ) . '</label></td>'
325325 . '<td>' . Xml::input( 'mwProtect-expiry', 60, $this->mExpiry, $attribs ) . '</td>'
326326 . '</tr>';
327327 }
Index: trunk/phase3/includes/GlobalFunctions.php
@@ -327,20 +327,6 @@
328328 }
329329
330330 /**
331 - * Get a message in the user interface language and replace wiki
332 - * links with clickable ones, escaping other HTML
333 - *
334 - * @param string $key Message key
335 - * @return string
336 - */
337 -function wfMsgWithLinks( $key ) {
338 - global $wgUser;
339 - $args = func_get_args();
340 - return $wgUser->getSkin()->formatLinksInComment( htmlspecialchars(
341 - call_user_func_array( 'wfMsg', $args ) ) );
342 -}
343 -
344 -/**
345331 * Same as above except doesn't transform the message
346332 */
347333 function wfMsgNoTrans( $key ) {
@@ -383,19 +369,6 @@
384370 }
385371
386372 /**
387 - * Get a message in the content language and replace wiki
388 - * links with clickable ones, escaping other HTML
389 - *
390 - * @param string $key Message key
391 - * @return string
392 - */
393 -function wfMsgForContentWithLinks( $key ) {
394 - global $wgUser;
395 - return $wgUser->getSkin()->formatLinksInComment( htmlspecialchars(
396 - call_user_func_array( 'wfMsgForContent', func_get_args() ) ) );
397 -}
398 -
399 -/**
400373 * Same as above except doesn't transform the message
401374 */
402375 function wfMsgForContentNoTrans( $key ) {
Index: trunk/phase3/includes/SpecialWithoutinterwiki.php
@@ -14,7 +14,7 @@
1515 }
1616
1717 function getPageHeader() {
18 - return '<p>' . wfMsgWithLinks( 'withoutinterwiki-header' ) . '</p>';
 18+ return '<p>' . wfMsgExt( 'withoutinterwiki-header', array( 'parseinline' ) ) . '</p>';
1919 }
2020
2121 function sortDescending() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r23104Merged revisions 23087-23102 via svnmerge from...david21:40, 19 June 2007

Status & tagging log