r23045 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23044‎ | r23045 | r23046 >
Date:09:49, 17 June 2007
Author:david
Status:old
Tags:
Comment:
trivial rearrangement of functions in the source file
Modified paths:
  • /branches/liquidthreads/extensions/LqtExtension.php (modified) (history)

Diff [purge]

Index: branches/liquidthreads/extensions/LqtExtension.php
@@ -107,7 +107,8 @@
108108 static protected $occupied_titles = array();
109109
110110 /*************************
111 - * Utlity methods *
 111+ * (1) linking to liquidthreads pages and
 112+ * (2) figuring out what page you're on and what you need to do.
112113 *************************/
113114
114115 function queryStringFromArray( $vars ) {
@@ -139,22 +140,12 @@
140141 return $title->getFullURL( $query );
141142 }
142143
143 - /*************************
144 - * Simple HTML methods *
145 - *************************/
 144+ /*************************************************************
 145+ * Editing methods (here be dragons) *
 146+ * Forget dragons: This section distorts the rest of the code *
 147+ * like a star bending spacetime around itself. *
 148+ *************************************************************/
146149
147 - function openDiv( $class='', $id='' ) {
148 - $this->output->addHTML( wfOpenElement( 'div', array('class'=>$class, 'id'=>$id) ) );
149 - }
150 -
151 - function closeDiv() {
152 - $this->output->addHTML( wfCloseElement( 'div' ) );
153 - }
154 -
155 - /************************************
156 - * Editing methods (here be dragons) *
157 - *************************************/
158 -
159150 /**
160151 * Return an HTML form element whose value is gotten from the request.
161152 * TODO: figure out a clean way to expand this to other forms.
@@ -468,6 +459,14 @@
469460 $this->output->addHTML( wfCloseElement( 'dl') );
470461 $this->headerLevel -= 1;
471462 }
 463+
 464+ function openDiv( $class='', $id='' ) {
 465+ $this->output->addHTML( wfOpenElement( 'div', array('class'=>$class, 'id'=>$id) ) );
 466+ }
 467+
 468+ function closeDiv() {
 469+ $this->output->addHTML( wfCloseElement( 'div' ) );
 470+ }
472471
473472 function showSummary($t) {
474473 if ( !$t->summary() ) return;

Status & tagging log