r23028 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23027‎ | r23028 | r23029 >
Date:08:08, 16 June 2007
Author:midom
Status:old
Tags:
Comment:
varchars exist for a reason (or rather, static length doesn't add too much performance in paged datastores) - still needs updater and sync to all other table definition files
Modified paths:
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tables.sql
@@ -947,7 +947,7 @@
948948 -- The URL of the wiki, with "$1" as a placeholder for an article name.
949949 -- Any spaces in the name will be transformed to underscores before
950950 -- insertion.
951 - iw_url char(127) NOT NULL,
 951+ iw_url varchar(127) NOT NULL,
952952
953953 -- A boolean value indicating whether the wiki is in this project
954954 -- (used, for example, to detect redirect loops)
@@ -965,14 +965,14 @@
966966 --
967967 CREATE TABLE /*$wgDBprefix*/querycache (
968968 -- A key name, generally the base name of of the special page.
969 - qc_type char(32) NOT NULL,
 969+ qc_type varchar(32) binary NOT NULL,
970970
971971 -- Some sort of stored value. Sizes, counts...
972972 qc_value int(5) unsigned NOT NULL default '0',
973973
974974 -- Target namespace+title
975975 qc_namespace int NOT NULL default '0',
976 - qc_title char(255) binary NOT NULL default '',
 976+ qc_title varchar(255) binary NOT NULL default '',
977977
978978 KEY (qc_type,qc_value)
979979
@@ -982,7 +982,7 @@
983983 -- For a few generic cache operations if not using Memcached
984984 --
985985 CREATE TABLE /*$wgDBprefix*/objectcache (
986 - keyname char(255) binary NOT NULL default '',
 986+ keyname varchar(255) binary NOT NULL default '',
987987 value mediumblob,
988988 exptime datetime,
989989 UNIQUE KEY (keyname),
@@ -1105,18 +1105,18 @@
11061106 -- Used for caching expensive grouped queries that need two links (for example double-redirects)
11071107 CREATE TABLE /*$wgDBprefix*/querycachetwo (
11081108 -- A key name, generally the base name of of the special page.
1109 - qcc_type char(32) NOT NULL,
 1109+ qcc_type varchar(32) NOT NULL,
11101110
11111111 -- Some sort of stored value. Sizes, counts...
11121112 qcc_value int(5) unsigned NOT NULL default '0',
11131113
11141114 -- Target namespace+title
11151115 qcc_namespace int NOT NULL default '0',
1116 - qcc_title char(255) binary NOT NULL default '',
 1116+ qcc_title varchar(255) binary NOT NULL default '',
11171117
11181118 -- Target namespace+title2
11191119 qcc_namespacetwo int NOT NULL default '0',
1120 - qcc_titletwo char(255) binary NOT NULL default '',
 1120+ qcc_titletwo varchar(255) binary NOT NULL default '',
11211121
11221122 KEY qcc_type (qcc_type,qcc_value),
11231123 KEY qcc_title (qcc_type,qcc_namespace,qcc_title),

Follow-up revisions

RevisionCommit summaryAuthorDate
r23039Merged revisions 22967-23037 via svnmerge from...david20:15, 16 June 2007

Status & tagging log