r22938 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22937‎ | r22938 | r22939 >
Date:22:04, 12 June 2007
Author:aaron
Status:old
Tags:
Comment:
*Make messages more clear, removed unused one
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevsPage.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -759,7 +759,8 @@
760760 $simpleTag = true;
761761 # Construct some tagging
762762 if( !$wgOut->isPrintable() ) {
763 - $tag .= wfMsgExt('revreview-newest', array('parseinline'), $tfrev->fr_rev_id, $time, $revs_since);
 763+ $msg = $quality ? 'revreview-newest-quality' : 'revreview-newest-basic';
 764+ $tag .= wfMsgExt($msg, array('parseinline'), $tfrev->fr_rev_id, $time, $revs_since);
764765 # Hide clutter
765766 $tag .= ' <a href="javascript:toggleRevRatings()">' . wfMsg('revreview-toggle') . '</a>';
766767 $tag .= '<span id="mwrevisionratings" style="display:none">' .
@@ -849,7 +850,8 @@
850851 $flags = $this->getFlagsForRevision( $tfrev->fr_rev_id );
851852 $revs_since = parent::getRevCountSince( $editform->mArticle->getID(), $tfrev->fr_rev_id );
852853 # Construct some tagging
853 - $tag = wfMsgExt('revreview-newest', array('parseinline'), $tfrev->fr_rev_id, $time, $revs_since );
 854+ $msg = $this->isQuality( $flags ) ? 'revreview-newest-quality' : 'revreview-newest-basic';
 855+ $tag = wfMsgExt($msg, array('parseinline'), $tfrev->fr_rev_id, $time, $revs_since );
854856 # Hide clutter
855857 $tag .= ' <a href="javascript:toggleRevRatings()">' . wfMsg('revreview-toggle') . '</a>';
856858 $tag .= '<span id="mwrevisionratings" style="display:none">' .
Index: trunk/extensions/FlaggedRevs/FlaggedRevsPage.i18n.php
@@ -18,10 +18,14 @@
1919 'revreview-rating' => 'It was rated as:',
2020 'revreview-noflagged' => 'There are no reviewed revisions of this page, so it may \'\'\'not\'\'\' have been
2121 [[Help:Article validation|checked]] for quality.',
22 - 'revreview-newest' => 'The [{{fullurl:{{FULLPAGENAMEE}}|stable=1}} latest stable revision]
 22+
 23+ 'revreview-newest-basic' => 'The [{{fullurl:{{FULLPAGENAMEE}}|stable=1}} latest sighted revision]
2324 ([{{fullurl:Special:Stableversions|page={{FULLPAGENAMEE}}}} see all]) of this page was [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved]
2425 on <i>$2</i>. <br/> There {{plural:$3|is $3 revision|are $3 revisions}} ([{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}} changes]) awaiting review.',
25 - 'revreview-basic' => 'This is the latest [[Help:Article validation|stable]] revision of this page,
 26+ 'revreview-newest-quality' => 'The [{{fullurl:{{FULLPAGENAMEE}}|stable=1}} latest quality revision]
 27+ ([{{fullurl:Special:Stableversions|page={{FULLPAGENAMEE}}}} see all]) of this page was [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved]
 28+ on <i>$2</i>. <br/> There {{plural:$3|is $3 revision|are $3 revisions}} ([{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur}} changes]) awaiting review.',
 29+ 'revreview-basic' => 'This is the latest [[Help:Article validation|sighted]] revision of this page,
2630 [{{fullurl:Special:Log|type=review&page={{FULLPAGENAMEE}}}} approved] on <i>$4</i>. The [{{fullurl:{{FULLPAGENAMEE}}|stable=0}} current revision]
2731 is usually [{{fullurl:{{FULLPAGENAMEE}}|action=edit}} editable] and more up to date. There {{plural:$3|is $3 revision|are $3 revisions}}
2832 ([{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=$2}} changes]) awaiting review.',
@@ -35,7 +39,7 @@
3640 'revreview-toggle' => '(toggle details)',
3741 'revreview-note' => '[[User:$1]] made the following notes [[Help:Article validation|reviewing]] this revision:',
3842
39 - 'hist-stable' => '[stable]',
 43+ 'hist-stable' => '[sighted]',
4044 'hist-quality' => '[quality]',
4145
4246 'flaggedrevs' => 'Flagged Revisions',
@@ -49,11 +53,9 @@
5054 'revisionreview' => 'Review revisions',
5155 'revreview-main' => 'You must select a particular revision from a content page in order to review.
5256
53 - See the [[Special:Unreviewedpages]] for a list of
54 - unreviewed pages.',
 57+ See the [[Special:Unreviewedpages]] for a list of unreviewed pages.',
5558 'revreview-selected' => "Selected revision of '''$1:'''",
56 - 'revreview-text' => "Stable versions are set as the default content on page view rather than the newest
57 - revision.",
 59+ 'revreview-text' => "Stable versions are set as the default content on page view rather than the newest revision.",
5860 'revreview-toolow' => 'You must at least rate each of the below attributes higher than "unapproved" in order
5961 for a revision to be considered reviewed. To depreciate a revision, set all fields to "unapproved".',
6062 'revreview-flag' => 'Review this revision (#$1):',
@@ -88,7 +90,6 @@
8991 'stableversions-none' => '[[:$1]] has no reviewed revisions.',
9092 'stableversions-list' => 'The following is a list of revisions of [[:$1]] that have been reviewed:',
9193 'stableversions-review' => 'Reviewed on <i>$1</i>',
92 - 'stableversions-quality' => '[Latest quality revision]',
9394
9495 'review-diff2stable' => 'Diff to the last stable revision',
9596 'review-diff2oldest' => "Diff to the oldest revision",
@@ -186,7 +187,6 @@
187188 'stableversions-none' => '[[:$1]] hat keine geprüften Versionen.',
188189 'stableversions-list' => 'Dies ist die Liste der geprüften Versionen von [[:$1]]:',
189190 'stableversions-review' => 'geprüft am <i>$1</i>',
190 - 'stableversions-quality' => '[Letzte Version mit Qualitätsbewertung]',
191191
192192 'review-diff2stable' => 'Unterschied zur letzten stabilen Version',
193193 'review-diff2oldest' => "Unterschied zur ältesten Version",
@@ -268,7 +268,6 @@
269269 'stableversions-none' => '[[:$1]] não possui edições críticas.',
270270 'stableversions-list' => 'A seguir, uma lista das edições de [[:$1]] que são edições críticas:',
271271 'stableversions-review' => 'Criticada em <i>$1</i>',
272 - 'stableversions-quality' => '[Edição mais recente marcada como de qualidade]',
273272
274273 'review-diff2stable' => 'Comparar com a edição crítica mais recente',
275274 'review-diff2oldest' => "Comparar com a edição mais antiga",
@@ -359,7 +358,6 @@
360359 'stableversions-none' => '[[:$1]] nemá skontrolované verzie.',
361360 'stableversions-list' => 'Nasleduje zoznam verzií stránky [[:$1]], ktoré boli skontrolované:',
362361 'stableversions-review' => 'Skontrolované <i>$1</i>',
363 - 'stableversions-quality' => '[Najnovšia kvalitná verzia]',
364362 'review-diff2stable' => 'Rozdiely oproti poslednej stabilnej verzii',
365363 'review-diff2oldest' => 'Rozdiely oproti najstaršej verzii',
366364 'unreviewedpages' => 'Neskontrolované stránky',

Status & tagging log