r22845 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22844‎ | r22845 | r22846 >
Date:18:12, 8 June 2007
Author:robchurch
Status:old
Tags:
Comment:
(bug 9058) Introduce '--aconf' option for all maintenance scripts, to provide a path to the AdminSettings.php file
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/maintenance/commandLine.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/commandLine.inc
@@ -34,6 +34,7 @@
3535 $optionsWithArgs = array();
3636 }
3737 $optionsWithArgs[] = 'conf'; # For specifying the location of LocalSettings.php
 38+$optionsWithArgs[] = 'aconf'; # As above for AdminSettings.php
3839
3940 $self = array_shift( $argv );
4041 $IP = realpath( dirname( __FILE__ ) . '/..' );
@@ -181,9 +182,12 @@
182183 require_once( $settingsFile );
183184 /* ini_set( 'include_path', ".$sep$IP$sep$IP/includes$sep$IP/languages$sep$IP/maintenance" ); */
184185
185 - if ( is_readable( $IP.'/AdminSettings.php' ) ) {
186 - require_once( $IP.'/AdminSettings.php' );
187 - }
 186+ $adminSettings = isset( $options['aconf'] )
 187+ ? $options['aconf']
 188+ : "{$IP}/AdminSettings.php";
 189+ if( is_readable( $adminSettings ) )
 190+ require_once( $adminSettings );
 191+
188192 }
189193
190194 # Turn off output buffering again, it might have been turned on in the settings files
Index: trunk/phase3/RELEASE-NOTES
@@ -70,6 +70,8 @@
7171 * (bug 5908) Add "DEFAULTSORTKEY" and "DEFAULTCATEGORYSORT" aliases for
7272 "DEFAULTSORT" magic word
7373 * (bug 10181) Support the XCache object caching mechanism
 74+* (bug 9058) Introduce '--aconf' option for all maintenance scripts, to provide
 75+ a path to the AdminSettings.php file
7476
7577 == Bugfixes since 1.10 ==
7678

Follow-up revisions

RevisionCommit summaryAuthorDate
r22857Merged revisions 22811-22855 via svnmerge from...david00:48, 9 June 2007

Status & tagging log