r22834 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22833‎ | r22834 | r22835 >
Date:12:12, 8 June 2007
Author:aaron
Status:old
Tags:
Comment:
*Show CIDR for range blocks, state XFF blurb more clearly
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser.i18n.php (modified) (history)
  • /trunk/extensions/CheckUser/CheckUser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/CheckUser_body.php
@@ -374,7 +374,10 @@
375375 if( $block->load( $ip, $users_ids[$name] ) ) {
376376 $userpage = Title::makeTitle( NS_USER, $name );
377377 $blocklog = $sk->makeKnownLinkObj( $logs, wfMsgHtml('blockedtitle'), 'type=block&page=' . urlencode( $userpage->getPrefixedText() ) );
378 - $s .= '<strong>(' . $blocklog . ')</strong><br/>';
 378+ if( IP::isIPAddress($block->mAddress) && strpos($block->mAddress,'/') )
 379+ $s .= '<strong>(' . $blocklog . ' - ' . $block->mAddress . ')</strong><br/>';
 380+ else
 381+ $s .= '<strong>(' . $blocklog . ')</strong><br/>';
379382 }
380383 $s .= '<ol>';
381384 # List out each IP/XFF combo for this username, and add the user agent for each
Index: trunk/extensions/CheckUser/CheckUser.i18n.php
@@ -9,7 +9,7 @@
1010
1111 $wgCheckUserMessages['en'] = array(
1212 'checkuser-summary' => 'This tool scans recent changes to retrieve the IPs used by a user or show the edit/user data for an IP.
13 - Users and edits can be retrieved with an XFF IP by appending the IP with "/xff". IPv4 (CIDR 16-32) and IPv6 (CIDR 64-128) are supported.
 13+ Users and edits by a client IP can be retrieved via XFF headers by appending the IP with "/xff". IPv4 (CIDR 16-32) and IPv6 (CIDR 64-128) are supported.
1414 No more than 5000 edits will be returned for performance reasons. Use this in accordance with policy.',
1515 'checkuser-logcase' => 'The log search is case sensitive.',
1616 'checkuser' => 'Check user',

Status & tagging log