r22813 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r22812‎ | r22813 | r22814 >
Date:14:02, 7 June 2007
Author:greg
Status:old
Tags:
Comment:
Return true/false, not o/not-0 for relation checking functions, for those parts of the code that demand "result === false" rather than saying (!result)
Modified paths:
  • /trunk/phase3/includes/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DatabasePostgres.php
——@@ -923,7 +923,7 @@
924924 $count = $res ? pg_num_rows($res) : 0;
925925 if ($res)
926926 $this->freeResult( $res );
927 - return $count;
 927+ return $count ? true : false;
928928 }
929929
930930 /*

Follow-up revisions

RevisionCommit summaryAuthorDate
r22857Merged revisions 22811-22855 via svnmerge from...david00:48, 9 June 2007

Status & tagging log