r22809 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22808‎ | r22809 | r22810 >
Date:03:34, 7 June 2007
Author:david
Status:old
Tags:
Comment:
in light of the new archive behavior, we can rip out the suppress_summaries argument to showThread. threads are now always shown alongside summaries in the default implementation.
Modified paths:
  • /branches/liquidthreads/extensions/LqtExtension.php (modified) (history)

Diff [purge]

Index: branches/liquidthreads/extensions/LqtExtension.php
@@ -452,14 +452,12 @@
453453 }
454454 }
455455
456 - function showThread( $thread, $suppress_summaries = false ) {
 456+ function showThread( $thread ) {
457457 $this->showThreadHeading( $thread );
458458
459459 $touched = new Date($thread->touched());
460 - if( $thread->summary() && !$suppress_summaries ) {
 460+ if( $thread->summary() ) {
461461 $this->showSummary($thread);
462 - $this->output->addHTML( "<a href=\"{$this->permalinkUrl($thread)}\" class=\"lqt_thread_show_summary\">Show this thread</a>" );
463 - return;
464462 } else if ( $touched->isBefore(Date::now()->nDaysAgo($this->archive_start_days))
465463 && !$thread->summary() && !$thread->superthread() ) {
466464 $this->output->addHTML("<p class=\"lqt_summary_notice\">If this discussion seems to be concluded, you are encouraged to <a href=\"{$this->permalinkUrl($thread, 'lqt_summarize=1')}\">write a summary</a>. There have been no changes here for at least $this->archive_start_days days.</p>");
@@ -745,11 +743,9 @@
746744
747745 if( $this->request->getBool('lqt_summarize') ) {
748746 $this->showSummarizeForm($t);
749 - } else if ( $t->summary() ) {
750 - $this->showSummary($t);
751747 }
752748
753 - $this->showThread($t, true);
 749+ $this->showThread($t);
754750 }
755751
756752 }

Status & tagging log