r22806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22805‎ | r22806 | r22807 >
Date:02:33, 7 June 2007
Author:river
Status:old
Tags:
Comment:
slayerd (1.5) unstable; urgency=low

* "data" figure appears non-useful, go back to RSS.
Modified paths:
  • /trunk/tools/slayerd/debian/changelog (modified) (history)
  • /trunk/tools/slayerd/debian/files (modified) (history)
  • /trunk/tools/slayerd/debian/slayerd.substvars (modified) (history)
  • /trunk/tools/slayerd/slayerd.cc (modified) (history)

Diff [purge]

Index: trunk/tools/slayerd/debian/changelog
@@ -1,3 +1,9 @@
 2+slayerd (1.5) unstable; urgency=low
 3+
 4+ * "data" figure appears non-useful, go back to RSS.
 5+
 6+ -- River Tarnell <river@wikimedia.org> Thu, 07 Jun 2007 02:31:47 +0000
 7+
28 slayerd (1.4) unstable; urgency=low
39
410 * Very large processes would cause integer overflow, kill too many
Index: trunk/tools/slayerd/debian/slayerd.substvars
@@ -1 +1 @@
2 -shlibs:Depends=libboost-filesystem1.33.1, libc6 (>= 2.5-5), libgcc1 (>= 1:4.1.1-12), libstdc++6 (>= 4.1.1-12)
 2+shlibs:Depends=libboost-filesystem1.33.1, libc6 (>= 2.5-5), libgcc1 (>= 1:4.2-20070516), libstdc++6 (>= 4.2-20070516)
Index: trunk/tools/slayerd/debian/files
@@ -1 +1 @@
2 -slayerd_1.4_amd64.deb admin extra
 2+slayerd_1.5_amd64.deb admin extra
Index: trunk/tools/slayerd/slayerd.cc
@@ -595,7 +595,7 @@
596596 u = &users[n];
597597 }
598598
599 - u->rss += p._mdata;
 599+ u->rss += p._mres;
600600 u->processes.push_back(p);
601601 }
602602
@@ -625,7 +625,7 @@
626626 % (bytes / 1024 / 1024)
627627 % (config.limit / 1024 / 1024)));
628628
629 - std::sort(u.processes.begin(), u.processes.end(), field_comparator<process, int, &process::_mdata>);
 629+ std::sort(u.processes.begin(), u.processes.end(), field_comparator<process, int, &process::_mres>);
630630
631631 while (bytes >= config.thresh && !u.processes.empty()) {
632632 process &p = u.processes[0];
@@ -635,7 +635,7 @@
636636 if (!config.debug)
637637 kill(p._pid, SIGKILL);
638638
639 - std::size_t thissize = std::size_t(p._mdata) * pagesize;
 639+ std::size_t thissize = std::size_t(p._mres) * pagesize;
640640
641641 log(str(boost::format(" killed process \"%s\" (pid %d) using %dM, usage now %dM")
642642 % comm % p._pid

Status & tagging log