r22779 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22778‎ | r22779 | r22780 >
Date:21:17, 5 June 2007
Author:brion
Status:old
Tags:
Comment:
* (bug 10149) Don't show full template list on section-0 edit
Oh PHP, how do I loathe thee? Let me count the ways:
1) 0 == '0'
2) 0 == ''
3) '0' != ''
Q.E.D.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1118,7 +1118,7 @@
11191119 if( !$this->preview && !$this->diff ) {
11201120 $wgOut->setOnloadHandler( 'document.editform.wpTextbox1.focus()' );
11211121 }
1122 - $templates = ($this->preview || $this->section) ? $this->mPreviewTemplates : $this->mArticle->getUsedTemplates();
 1122+ $templates = ($this->preview || $this->section != '') ? $this->mPreviewTemplates : $this->mArticle->getUsedTemplates();
11231123 $formattedtemplates = $sk->formatTemplates( $templates, $this->preview, $this->section != '');
11241124
11251125 global $wgUseMetadataEdit ;
Index: trunk/phase3/RELEASE-NOTES
@@ -132,7 +132,9 @@
133133 installation
134134 * (bug 9383) Don't set a default value for BLOB column in rc-deleted
135135 database patch
 136+* (bug 10149) Don't show full template list on section-0 edit
136137
 138+
137139 == MediaWiki API changes since 1.10 ==
138140
139141 (For ongoing development discussion, see http://www.mediawiki.org/wiki/API)

Follow-up revisions

RevisionCommit summaryAuthorDate
r22791Merged revisions 22747-22790 via svnmerge from...david09:21, 6 June 2007

Status & tagging log