r22777 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r22776‎ | r22777 | r22778 >
Date:19:06, 5 June 2007
Author:brion
Status:old
Tags:
Comment:
* Fix minor regression in media links to images that don't exist yet -- use dbkey form (with _ instead of space) when passing wpDestFile parameter. This matches previous behavior and avoids a warning on upload when the name is normalized. Fixes another parser test case regression.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
——@@ -684,7 +684,7 @@
685685 $class = 'internal';
686686 } else {
687687 $upload = SpecialPage::getTitleFor( 'Upload' );
688 - $url = $upload->getLocalUrl( 'wpDestFile=' . urlencode( $title->getText() ) );
 688+ $url = $upload->getLocalUrl( 'wpDestFile=' . urlencode( $title->getDbKey() ) );
689689 $class = 'new';
690690 }
691691 $alt = htmlspecialchars( $title->getText() );

Follow-up revisions

RevisionCommit summaryAuthorDate
r22791Merged revisions 22747-22790 via svnmerge from...david09:21, 6 June 2007

Status & tagging log