r22713 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22712‎ | r22713 | r22714 >
Date:19:20, 4 June 2007
Author:brion
Status:old
Tags:
Comment:
* (bug 10113) Fix double-click for view source on protected pages
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -440,7 +440,8 @@
441441 // XXX: attach this from javascript, same with section editing
442442 if($this->iseditable && $wgUser->getOption("editondblclick") )
443443 {
444 - $tpl->set('body_ondblclick', 'document.location = "' .$content_actions['edit']['href'] .'";');
 444+ $encEditUrl = wfEscapeJsString( $this->mTitle->getLocalUrl( $this->editUrlOptions() ) );
 445+ $tpl->set('body_ondblclick', 'document.location = "' . $encEditUrl . '";');
445446 } else {
446447 $tpl->set('body_ondblclick', false);
447448 }
Index: trunk/phase3/RELEASE-NOTES
@@ -109,6 +109,7 @@
110110 * (bug 10083) Fix for Special:Version breakage on PHP 5.2 with some hooks
111111 * (bug 3624) TeX: \ker, \hom, \arg, \dim treated like \sin & \cos
112112 * (bug 10132, 10134) Restore back-compatibility Image::imageUrl() function
 113+* (bug 10113) Fix double-click for view source on protected pages
113114
114115
115116 == MediaWiki API changes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r22717Merged revisions 22667-22715 via svnmerge from...david20:00, 4 June 2007

Status & tagging log