r22641 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22640‎ | r22641 | r22642 >
Date:00:03, 2 June 2007
Author:amidaniel
Status:old
Tags:
Comment:
(bug 10076) Modified so as to output whoever the original blockee is, regardless of whether it is an IP-range or not.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -792,13 +792,11 @@
793793 $msg = 'blockedtext';
794794 }
795795
796 - //If it's a range block, get the range in CIDR and hand it back.
797 - $ipRange = '';
798 - if ($wgUser->mBlock->mRangeStart != $wgUser->mBlock->mRangeEnd) {
799 - $ipRange = $wgUser->mBlock->mAddress;
800 - }
 796+ /* $ip returns who *is* being blocked, $intended contains who was meant to be blocked.
 797+ * This could be a username, an ip range, or a single ip. */
 798+ $intended = $wgUser->mBlock->mAddress;
801799
802 - $this->addWikiText( wfMsg( $msg, $link, $reason, $ip, $name, $blockid, $blockExpiry, $ipRange ) );
 800+ $this->addWikiText( wfMsg( $msg, $link, $reason, $ip, $name, $blockid, $blockExpiry, $intended ) );
803801
804802 # Don't auto-return to special pages
805803 if( $return ) {
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -939,8 +939,8 @@
940940
941941 The block was made by $1. The reason given is ''$2''.
942942
943 -Expiry of block: $6
944 -Effective range: $7
 943+Expiry of block: $6
 944+Intended blockee: $7
945945
946946 You can contact $1 or another [[{{MediaWiki:grouppage-sysop}}|administrator]] to discuss the block.
947947 You cannot use the 'email this user' feature unless a valid email address is specified in your
Index: trunk/phase3/RELEASE-NOTES
@@ -50,8 +50,8 @@
5151 * Display file history on local image description pages of shared images
5252 * Added $wgArticleRobotPolicies
5353 * (bug 10076) Additional parameter $7 added to MediaWiki:Blockedtext
54 - containing, if the user is blocked as the result of a range-block, the
55 - range whose block effects the user.
 54+ containing, the ip, ip range, or username whose block is affecting the
 55+ current user.
5656
5757 == Bugfixes since 1.10 ==
5858

Follow-up revisions

RevisionCommit summaryAuthorDate
r22652Merged revisions 22619-22651 via svnmerge from...david06:10, 2 June 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r22623(bug 10076) If a user is blocked as the result of a rangeblock, add the effec...amidaniel07:57, 1 June 2007