r22604 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22603‎ | r22604 | r22605 >
Date:17:15, 31 May 2007
Author:aaron
Status:old
Tags:
Comment:
*Use null for time/rev ID for templates/images when they don't exist, rather than "get the one from jan 1, 1970" :)
Modified paths:
  • /trunk/phase3/includes/Parser.php (modified) (history)
  • /trunk/phase3/includes/ParserOutput.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ParserOutput.php
@@ -103,7 +103,7 @@
104104 array('img_name' => $name),
105105 __METHOD__ );
106106 }
107 - $timestamp = $timestamp ? $timestamp : 0;
 107+ $timestamp = $timestamp ? $timestamp : null;
108108 $this->mImageTimestamps[$name] = $timestamp; // For versioning
109109 }
110110
Index: trunk/phase3/includes/Parser.php
@@ -3277,7 +3277,7 @@
32783278
32793279 if( $skip ) {
32803280 $text = false;
3281 - $this->mOutput->addTemplate( $title, $title->getArticleID(), 0 );
 3281+ $this->mOutput->addTemplate( $title, $title->getArticleID(), null );
32823282 break;
32833283 }
32843284 $rev = $id ? Revision::newFromId( $id ) : Revision::newFromTitle( $title );

Follow-up revisions

RevisionCommit summaryAuthorDate
r22619Merged revisions 22587-22618 via svnmerge from...david04:13, 1 June 2007