r22499 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22498‎ | r22499 | r22500 >
Date:04:28, 28 May 2007
Author:skierpage
Status:old
Tags:
Comment:
Fix for bug 10047: SMW doesn't display several errors in Imported from.
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_Factbox.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_Factbox.php
@@ -188,8 +188,8 @@
189189
190190 if (NULL != $error) {
191191 $datavalue = SMWDataValue::newTypedValue(new SMWErrorTypeHandler($error),$value);
192 - if (!$smwgStoreActive) {
193 - SMWFactbox::$semdata->addSpecialValue(SMW_SP_IMPORTED_FROM,$result);
 192+ if ($smwgStoreActive) {
 193+ SMWFactbox::$semdata->addSpecialValue(SMW_SP_IMPORTED_FROM, $datavalue);
194194 }
195195 return $datavalue;
196196 }

Status & tagging log