r22054 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r22053‎ | r22054 | r22055 >
Date:20:55, 9 May 2007
Author:hashar
Status:old
Tags:
Comment:
* Fix #6823: HTML dumping should not increment the page view counters.
* Small documentation for $wgDisableCounters.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/maintenance/dumpHTML.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/dumpHTML.inc
@@ -9,6 +9,10 @@
1010 require_once( 'includes/CategoryPage.php' );
1111 require_once( 'includes/RawPage.php' );
1212
 13+# Explicitly disable article view counter (bug 6823)
 14+global $wgDisableCounters;
 15+$wgDisableCounters = true;
 16+
1317 class DumpHTML {
1418 # Destination directory
1519 var $dest;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1337,7 +1337,11 @@
13381338 /** Lots of debugging output from SquidUpdate.php */
13391339 $wgDebugSquid = false;
13401340
 1341+/** Whereas to count the number of time an article is viewed.
 1342+ * Does not work if pages are cached (for example with squid).
 1343+ */
13411344 $wgDisableCounters = false;
 1345+
13421346 $wgDisableTextSearch = false;
13431347 $wgDisableSearchContext = false;
13441348 /**
Index: trunk/phase3/RELEASE-NOTES
@@ -51,8 +51,8 @@
5252 == Maintenance script changes since 1.10 ==
5353
5454 * Add support for wgMaxTocLevel option in parserTests
 55+* (bug 6823) dumpHTML: explicitly disable article view counter
5556
56 -
5757 == Languages updated since 1.10 ==
5858
5959 * Arabic (ar)