r21815 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r21814‎ | r21815 | r21816 >
Date:20:37, 2 May 2007
Author:nikerabbit
Status:old
Tags:
Comment:
* Added date headers to logs to make them a bit clearer
Modified paths:
  • /trunk/phase3/includes/LogPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogPage.php
@@ -92,7 +92,7 @@
9393 /**
9494 * @static
9595 */
96 - function validTypes() {
 96+ public static function validTypes() {
9797 global $wgLogTypes;
9898 return $wgLogTypes;
9999 }
@@ -100,7 +100,7 @@
101101 /**
102102 * @static
103103 */
104 - function isLogType( $type ) {
 104+ public static function isLogType( $type ) {
105105 return in_array( $type, LogPage::validTypes() );
106106 }
107107
@@ -122,7 +122,7 @@
123123 * @todo handle missing log types
124124 * @static
125125 */
126 - function logHeader( $type ) {
 126+ static function logHeader( $type ) {
127127 global $wgLogHeaders;
128128 return wfMsg( $wgLogHeaders[$type] );
129129 }
@@ -130,7 +130,7 @@
131131 /**
132132 * @static
133133 */
134 - function actionText( $type, $action, $title = NULL, $skin = NULL, $params = array(), $filterWikilinks=false, $translate=false ) {
 134+ static function actionText( $type, $action, $title = NULL, $skin = NULL, $params = array(), $filterWikilinks=false, $translate=false ) {
135135 global $wgLang, $wgContLang, $wgLogActions;
136136
137137 $key = "$type/$action";
@@ -235,7 +235,7 @@
236236 * Create a blob from a parameter array
237237 * @static
238238 */
239 - function makeParamBlob( $params ) {
 239+ static function makeParamBlob( $params ) {
240240 return implode( "\n", $params );
241241 }
242242
@@ -243,7 +243,7 @@
244244 * Extract a parameter array from a blob
245245 * @static
246246 */
247 - function extractParams( $blob ) {
 247+ static function extractParams( $blob ) {
248248 if ( $blob === '' ) {
249249 return array();
250250 } else {