r21801 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r21800‎ | r21801 | r21802 >
Date:16:02, 2 May 2007
Author:brion
Status:old
Tags:
Comment:
E_STRICT fixlets: more static method markers
Also fixed a public function which was listed as private in comments for some reason
Modified paths:
  • /trunk/phase3/includes/SearchEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SearchEngine.php
@@ -40,12 +40,10 @@
4141 * If an exact title match can be find, or a very slightly close match,
4242 * return the title. If no match, returns NULL.
4343 *
44 - * @static
4544 * @param string $term
4645 * @return Title
47 - * @private
4846 */
49 - function getNearMatch( $searchterm ) {
 47+ public static function getNearMatch( $searchterm ) {
5048 global $wgContLang;
5149
5250 $allSearchTerms = array($searchterm);
@@ -176,9 +174,8 @@
177175 /**
178176 * Make a list of searchable namespaces and their canonical names.
179177 * @return array
180 - * @access public
181178 */
182 - function searchableNamespaces() {
 179+ public static function searchableNamespaces() {
183180 global $wgContLang;
184181 $arr = array();
185182 foreach( $wgContLang->getNamespaces() as $ns => $name ) {