r21534 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r21533‎ | r21534 | r21535 >
Date:16:23, 24 April 2007
Author:brion
Status:old
Tags:
Comment:
Remove use of unused fields -- undefined variables spewing PHP notices on logged actions
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/CheckUser.php
@@ -45,12 +45,6 @@
4646
4747 $agent = wfGetAgent();
4848
49 - $rc_actiontext='';
50 - if ( $rc_type==RC_LOG ) {
51 - $title = Title::newFromText( $rc_title, $rc_namespace );
52 - $rc_actiontext = LogPage::actionText( $rc_log_type, $rc_log_action, $title, NULL, LogPage::extractParams($rc_params), false, false, true );
53 - }
54 -
5549 $dbw->insert( 'cu_changes',
5650 array(
5751 'cuc_namespace' => $rc_namespace,
@@ -58,7 +52,7 @@
5953 'cuc_minor' => $rc_minor,
6054 'cuc_user' => $rc_user,
6155 'cuc_user_text' => $rc_user_text,
62 - 'cuc_actiontext' => $rc_actiontext,
 56+ 'cuc_actiontext' => '',
6357 'cuc_comment' => $rc_comment,
6458 'cuc_page_id' => $rc_cur_id,
6559 'cuc_this_oldid' => $rc_this_oldid,