r21382 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r21381‎ | r21382 | r21383 >
Date:14:50, 19 April 2007
Author:greg
Status:old
Tags:
Comment:
Adjust GROUP BY for databases that need all items from SELECT
Modified paths:
  • /trunk/extensions/Nuke/SpecialNuke.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Nuke/SpecialNuke.php
@@ -142,7 +142,8 @@
143143 $fname,
144144 array(
145145 'ORDER BY' => 'rc_timestamp DESC',
146 - 'GROUP BY' => 'rev_page' ) );
 146+ 'GROUP BY' => $dbr->implicitGroupby() ? 'rev_page' : 'rc_namespace, rc_title, rc_timestamp'
 147+ ) );
147148 $pages = array();
148149 while( $row = $dbr->fetchObject( $result ) ) {
149150 $pages[] = array( Title::makeTitle( $row->rc_namespace, $row->rc_title ), $row->edits );