r20524 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r20523‎ | r20524 | r20525 >
Date:13:30, 16 March 2007
Author:brion
Status:old
Tags:
Comment:
Remove the 'TODO' markings. The test runner can now indicate items which have never passed, and twiddling with the title constantly means they can't be tracked, so it's better not to have such markings.
Modified paths:
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
——@@ -1227,7 +1227,7 @@
12281228
12291229 # FIXME: this one has incorrect tag nesting still.
12301230 !! test
1231 -TODO: Table security: embedded pipes (http://mail.wikipedia.org/pipermail/wikitech-l/2006-April/034637.html)
 1231+Table security: embedded pipes (http://mail.wikipedia.org/pipermail/wikitech-l/2006-April/034637.html)
12321232 !! input
12331233 {|
12341234 | |[ftp://|x||]" onmouseover="alert(document.cookie)">test
——@@ -1400,7 +1400,7 @@
14011401 !! end
14021402
14031403 !! test
1404 -TODO: Link containing double-single-quotes '' (bug 4598)
 1404+Link containing double-single-quotes '' (bug 4598)
14051405 !! input
14061406 [[Lista d''e paise d''o munno]]
14071407 !! result
——@@ -2899,7 +2899,7 @@
29002900 !! end
29012901
29022902 !! test
2903 -TODO: message transform: <noinclude> in transcluded template (bug 4926)
 2903+message transform: <noinclude> in transcluded template (bug 4926)
29042904 !! options
29052905 msg
29062906 !! input
——@@ -2909,7 +2909,7 @@
29102910 !! end
29112911
29122912 !! test
2913 -TODO: message transform: <onlyinclude> in transcluded template (bug 4926)
 2913+message transform: <onlyinclude> in transcluded template (bug 4926)
29142914 !! options
29152915 msg
29162916 !! input
——@@ -2979,7 +2979,7 @@
29802980
29812981 !! test
29822982 Link to image page- image page normally doesn't exists, hence edit link
2983 -TODO: Add test with existing image page
 2983+Add test with existing image page
29842984 #<p><a href="https://www.mediawiki.org/wiki/Image:Test" title="Image:Test">Image:test</a>
29852985 !! input
29862986 [[:Image:test]]
——@@ -4363,7 +4363,7 @@
43644364 !! end
43654365
43664366 !! test
4367 -TODO: HTML bullet list, unclosed tags (bug 5497)
 4367+HTML bullet list, unclosed tags (bug 5497)
43684368 !! input
43694369 <ul>
43704370 <li>One
——@@ -4393,7 +4393,7 @@
43944394 !! end
43954395
43964396 !! test
4397 -TODO: HTML ordered list, unclosed tags (bug 5497)
 4397+HTML ordered list, unclosed tags (bug 5497)
43984398 !! input
43994399 <ol>
44004400 <li>One
——@@ -4433,7 +4433,7 @@
44344434 !! end
44354435
44364436 !! test
4437 -TODO: HTML nested bullet list, open tags (bug 5497)
 4437+HTML nested bullet list, open tags (bug 5497)
44384438 !! input
44394439 <ul>
44404440 <li>One
——@@ -4481,7 +4481,7 @@
44824482 !! end
44834483
44844484 !! test
4485 -TODO: HTML nested ordered list, open tags (bug 5497)
 4485+HTML nested ordered list, open tags (bug 5497)
44864486 !! input
44874487 <ol>
44884488 <li>One
——@@ -4727,7 +4727,7 @@
47284728 !! end
47294729
47304730 !! test
4731 -TODO: Parsing optional HTML elements (Bug 6171)
 4731+Parsing optional HTML elements (Bug 6171)
47324732 !! options
47334733 !! input
47344734 <table>
——@@ -4793,7 +4793,7 @@
47944794 !! end
47954795
47964796 !! test
4797 -TODO: Inline HTML vs wiki block nesting
 4797+Inline HTML vs wiki block nesting
47984798 !! input
47994799 <b>Bold paragraph
48004800
——@@ -4806,7 +4806,7 @@
48074807
48084808
48094809 !!test
4810 -TODO: Mixing markup for italics and bold
 4810+Mixing markup for italics and bold
48114811 !! options
48124812 !! input
48134813 '''bold''''''bold''bolditalics'''''
——@@ -6000,7 +6000,7 @@
60016001 # XML error: Mismatched tag at byte 6120:
60026002 # ...<dd> </dt></dl> </dd...
60036003 !! test
6004 -TODO: dt/dd/dl test
 6004+dt/dd/dl test
60056005 !! input
60066006 :;;;::
60076007 !! result
——@@ -6017,7 +6017,7 @@
60186018
60196019 # Images with the "|" character in external URLs in comment tags; Eats half the comment, leaves unmatched "</a>" tag.
60206020 !! test
6021 -TODO: Images with the "|" character in the comment
 6021+Images with the "|" character in the comment
60226022 !! input
60236023 [[image:Foobar.jpg|thumb|An [http://test/?param1=|left|&param2=|x external] URL]]
60246024 !! result
——@@ -6085,7 +6085,7 @@
60866086
60876087 # Question: should result be "/index.php?title=Subpage_test/L1&amp;action=edit" instead?
60886088 !! test
6089 -TODO: Parents of subpages, two levels up, without trailing slash or name.
 6089+Parents of subpages, two levels up, without trailing slash or name.
60906090 !! options
60916091 subpage title=[[Subpage test/L1/L2/L3]]
60926092 !! input
——@@ -6098,7 +6098,7 @@
60996099 # Question: Why should the link text in the above test be "../..", yet in this test the "../.." part is silently dropped?
61006100 # Current result: <p><a href="https://www.mediawiki.org/index.php?title=Subpage_test/L1////&amp;action=edit" class="new" title="Subpage test/L1////">///
61016101 !! test
6102 -TODO: Parents of subpages, two levels up, with lots of extra trailing slashes.
 6102+Parents of subpages, two levels up, with lots of extra trailing slashes.
61036103 !! options
61046104 subpage title=[[Subpage test/L1/L2/L3]]
61056105 !! input
——@@ -6123,7 +6123,7 @@
61246124 !! end
61256125
61266126 !! test
6127 -TODO: Don't fall for the self-closing div
 6127+Don't fall for the self-closing div
61286128 !! input
61296129 <div>hello world</div/>
61306130 !! result