r20292 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r20291‎ | r20292 | r20293 >
Date:15:30, 9 March 2007
Author:river
Status:old
Tags:
Comment:
use Revision::selectFields for PageHistory
Modified paths:
  • /trunk/phase3/includes/PageHistory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/PageHistory.php
@@ -387,8 +387,7 @@
388388
389389 $res = $dbr->select(
390390 'revision',
391 - array('rev_id', 'rev_page', 'rev_text_id', 'rev_user', 'rev_comment', 'rev_user_text',
392 - 'rev_timestamp', 'rev_minor_edit', 'rev_deleted', 'rev_len'),
 391+ Revision::selectFields(),
393392 array_merge(array("rev_page=$page_id"), $offsets),
394393 $fname,
395394 array('ORDER BY' => "rev_timestamp $dirs",
@@ -530,8 +529,7 @@
531530 function getQueryInfo() {
532531 return array(
533532 'tables' => 'revision',
534 - 'fields' => array('rev_id', 'rev_page', 'rev_text_id', 'rev_user', 'rev_comment', 'rev_user_text',
535 - 'rev_timestamp', 'rev_minor_edit', 'rev_deleted', 'rev_len'),
 533+ 'fields' => Revision::selectFields(),
536534 'conds' => array('rev_page' => $this->mPageHistory->mTitle->getArticleID() ),
537535 'options' => array( 'USE INDEX' => 'page_timestamp' )
538536 );