r19937 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19936‎ | r19937 | r19938 >
Date:10:14, 15 February 2007
Author:mkroetzsch
Status:old
Tags:
Comment:
Update for XHTML conformance
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialSearchTriple.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php
@@ -44,16 +44,16 @@
4545 $spectitle = Title::makeTitle( NS_SPECIAL, 'Ask' );
4646 $docutitle = Title::newFromText(wfMsg('smw_ask_doculink'), NS_HELP);
4747 $html = wfMsg('smw_ask_docu', $docutitle->getFullURL()) . "\n" .
48 - '<form name="ask" action="' . $spectitle->escapeLocalURL() . '" method="GET">' . "\n";
 48+ '<form name="ask" action="' . $spectitle->escapeLocalURL() . '" method="get">' . "\n";
4949 $html .= '<textarea name="query" cols="40" rows="6">' . htmlspecialchars($query) . '</textarea><br />' . "\n";
5050
5151 if ($smwgIQSortingEnabled) {
5252 $html .= wfMsg('smw_ask_sortby') . ' <input type="text" name="sort" value="' .
5353 htmlspecialchars($sort) . '"/> <select name="order"><option ';
5454 // TODO: don't show sort widgets if sorting is not enabled
55 - if ($order == 'ASC') $html .= 'selected ';
 55+ if ($order == 'ASC') $html .= 'selected="selected" ';
5656 $html .= 'value="ASC">' . wfMsg('smw_ask_ascorder') . '</option><option ';
57 - if ($order == 'DESC') $html .= 'selected ';
 57+ if ($order == 'DESC') $html .= 'selected="selected" ';
5858 $html .= 'value="DESC">' . wfMsg('smw_ask_descorder') . '</option></select> <br />';
5959 }
6060 $html .= '<br /><input type="submit" value="' . wfMsg('smw_ask_submit') . "\"/>\n</form>";
Index: trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialSearchTriple.php
@@ -65,7 +65,7 @@
6666
6767 $title = Title::makeTitle( NS_SPECIAL, 'SearchTriple' );
6868
69 - $form .= '<form name="tripleSearch" action="' . $title->escapeLocalURL() . '" method="GET"><input type="hidden" name="title" value="' . $title->getPrefixedText() . '"/>';
 69+ $form .= '<form name="tripleSearch" action="' . $title->escapeLocalURL() . '" method="get"><input type="hidden" name="title" value="' . $title->getPrefixedText() . '"/>';
7070 $form .= wfMsg('smw_searchtriple_docu') . "\n\n";
7171 // $form .=
7272 // '<input id="rel" type="radio" name="searchtype" value="relation" checked="checked" /><label for="rel">Relation</label>'.

Status & tagging log