r19898 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19897‎ | r19898 | r19899 >
Date:21:33, 12 February 2007
Author:brion
Status:old
Tags:
Comment:
Revert r19877; no reason is given for it but it breaks things such as parameter substitution of text that includes {{braces}}. An example of breakage is the automated deletion comments, where it expands template contents unexpectedly
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -380,15 +380,10 @@
381381 * @return String: the requested message.
382382 */
383383 function wfMsgReal( $key, $args, $useDB = true, $forContent=false, $transform = true ) {
384 - global $wgMessageCache;
385 -
386384 $fname = 'wfMsgReal';
387385 wfProfileIn( $fname );
388 - $message = wfMsgGetKey( $key, $useDB, $forContent, false);
 386+ $message = wfMsgGetKey( $key, $useDB, $forContent, $transform );
389387 $message = wfMsgReplaceArgs( $message, $args );
390 - if ( $transform && isset( $wgMessageCache ) ) {
391 - $message = $wgMessageCache->transform( $message );
392 - }
393388 wfProfileOut( $fname );
394389 return $message;
395390 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r19877* Get messages to actually transform (use magic phrases)aaron06:31, 11 February 2007