r19810 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r19809‎ | r19810 | r19811 >
Date:03:30, 7 February 2007
Author:simetrical
Status:old
Tags:
Comment:
* Fix regression from r19781 causing the little arrow next to section names in history comments to disappear: call to Skin::commentBlock short-circuits other stuff in Skin::revComment. Thanks to cesarb for spotting the issue.
Modified paths:
  • /trunk/phase3/includes/PageHistory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/PageHistory.php
——@@ -224,7 +224,7 @@
225225 $s .= " <span class=\"history-deleted\"><span class=\"comment\">" .
226226 wfMsgHtml( 'rev-deleted-comment' ) . "</span></span>";
227227 } else {
228 - $s .= $this->mSkin->commentBlock( $rev->getComment() );
 228+ $s .= $this->mSkin->revComment( $rev );
229229 }
230230
231231 if ($notificationtimestamp && ($row->rev_timestamp >= $notificationtimestamp)) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r19781*Enforce Hiderevision right better and some minor cleanup.aaron06:12, 5 February 2007