r19782 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r19781‎ | r19782 | r19783 >
Date:08:24, 5 February 2007
Author:erik
Status:old
Tags:
Comment:
-minor code fix
-add stylesheets&javascript to headers without requiring hacks
Modified paths:
  • /trunk/extensions/Wikidata/App.php (added) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/Wikidata.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/suggest.css (added) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/tables.css (added) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/tmp (deleted) (history)
  • /trunk/extensions/Wikidata/README (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/App.php
——@@ -0,0 +1,17 @@
 2+<?php
 3+$wgHooks['BeforePageDisplay'][]='addWikidataHeader';
 4+$wgCustomHandlerPath = array('*'=>"{$IP}/extensions/Wikidata/OmegaWiki/");
 5+require_once("{$IP}/extensions/Wikidata/SpecialLanguages.php");
 6+require_once("{$IP}/extensions/Wikidata/OmegaWiki/SpecialSuggest.php");
 7+require_once("{$IP}/extensions/Wikidata/OmegaWiki/SpecialDatasearch.php");
 8+require_once("{$IP}/extensions/Wikidata/OmegaWiki/SpecialTransaction.php");
 9+require_once("{$IP}/extensions/Wikidata/OmegaWiki/SpecialNeedsTranslation.php");
 10+
 11+function addWikidataHeader() {
 12+ global $wgOut,$wgScriptPath;
 13+ $wgOut->addScript("<script type='text/javascript' src='{$wgScriptPath}/extensions/Wikidata/OmegaWiki/suggest.js'></script>");
 14+ $wgOut->addLink(array('rel'=>'stylesheet','type'=>'text/css','media'=>'screen, projection','href'=>"{$wgScriptPath}/extensions/Wikidata/OmegaWiki/suggest.css"));
 15+ $wgOut->addLink(array('rel'=>'stylesheet','type'=>'text/css','media'=>'screen, projection','href'=>"{$wgScriptPath}/extensions/Wikidata/OmegaWiki/tables.css"));
 16+
 17+}
 18+?>
\ No newline at end of file
Property changes on: trunk/extensions/Wikidata/App.php
___________________________________________________________________
Added: svn:eol-style
119 + native
Index: trunk/extensions/Wikidata/OmegaWiki/Wikidata.php
——@@ -74,14 +74,13 @@
7575
7676 $wgOut->enableClientCache(false);
7777
78 - $titleArray = $wgTitle->getTitleArray();
 78+ $title = $wgTitle->getPrefixedText();
7979
8080 if (!$this->showClassicPageTitles) {
81 - $titleArray["mainpart"] = $this->getTitle();
82 - $titleArray["namespace"] = "";
 81+ $title = $this->getTitle()->getText();
8382 }
8483
85 - $wgOut->setPageTitleArray($titleArray);
 84+ $wgOut->setPageTitle($title);
8685
8786 if ($this->showLanguageSelector)
8887 $wgOut->addHTML($this->getLanguageSelector());
Index: trunk/extensions/Wikidata/OmegaWiki/tables.css
——@@ -0,0 +1,153 @@
 2+/*
 3+ Copy
 4+ @import url("../../extensions/Wikidata/WiktionaryZ/tmp/tables.css");
 5+
 6+ into the appropriate stylesheets like
 7+ skins/monobook/main.css
 8+ skins/common/common.css
 9+*/
 10+
 11+/* Wikidata tables */
 12+
 13+.wiki-data-table td, .wiki-data-table th {
 14+ padding-top: 0px;
 15+ padding-bottom: 0px;
 16+ padding-left: 2px;
 17+ padding-right: 2px;
 18+ margin: 0px;
 19+ border: none;
 20+}
 21+
 22+.wiki-data-table th {
 23+ background-color: #EEEEEE;
 24+ text-align: left;
 25+ vertical-align: bottom;
 26+ white-space: nowrap;
 27+}
 28+
 29+.wiki-data-table th.sortable {
 30+ cursor: pointer;
 31+}
 32+
 33+.wiki-data-table td.column-odd {
 34+ background-color: #F6F6F6;
 35+}
 36+
 37+.wiki-data-table td.column-even {
 38+ background-color: #FFFFFF;
 39+}
 40+.boolean {
 41+ text-align: center;
 42+}
 43+
 44+.integer {
 45+ text-align: right;
 46+}
 47+
 48+.language, .text, .short-text {
 49+ text-align: left;
 50+}
 51+
 52+/*.wiki-data-table td.language {
 53+ font-style: italic;
 54+}*/
 55+
 56+.wiki-data-table td.text {
 57+ padding-bottom: 4px;
 58+}
 59+
 60+.wiki-data-table td {
 61+ vertical-align: top;
 62+}
 63+
 64+.wiki-data-table td.remove {
 65+ text-align: center;
 66+ background-color: #EEEEEE;
 67+}
 68+
 69+.wiki-data-table tr.to-be-removed td.column-odd, .wiki-data-table tr.to-be-removed td.remove {
 70+ background: #FFD8C0;
 71+}
 72+
 73+.wiki-data-table tr.to-be-removed td.column-even {
 74+ background: #FFE8D0;
 75+}
 76+
 77+.wiki-data-table tr.to-be-removed th {
 78+ background: #FFD0B2;
 79+}
 80+
 81+.wiki-data-table th.remove, .wiki-data-table th.input-rows {
 82+ font-weight: normal;
 83+ padding-left: 4px;
 84+ padding-right: 4px;
 85+}
 86+
 87+.wiki-data-table td .wiki-data-table td textarea, li .wiki-data-table td textarea {
 88+ width: auto;
 89+}
 90+
 91+td.add {
 92+ text-align: center;
 93+}
 94+
 95+/* Toggle */
 96+
 97+.toggle {
 98+ cursor: pointer;
 99+ text-indent: 0px;
 100+ margin: 0px;
 101+ /*color: #000000;
 102+ border-width: 1px;
 103+ border-color: #AAAAAA;
 104+ border-style: dotted;
 105+ padding-left: 0px;
 106+ font-size: 80%;*/
 107+}
 108+
 109+/* Attribute list */
 110+
 111+ul.collapsable-items {
 112+ list-style: none;
 113+ list-style-image: none;
 114+ list-style-type: none;
 115+}
 116+
 117+.collapsable-items .toggle {
 118+ margin-left: 0px;
 119+ text-indent: 0px;
 120+}
 121+
 122+/* Option panel */
 123+
 124+.option-panel {
 125+ margin: 8px 4px 4px 4px;
 126+ padding: 8px;
 127+ border-style: solid;
 128+ border-width: 1px;
 129+ border-color: #AAAAAA;
 130+}
 131+
 132+.option-panel, .option-panel th, .option-panel td {
 133+ background-color: #F5F5F5;
 134+}
 135+
 136+.option-panel th {
 137+ padding-right: 8px;
 138+ white-space: nowrap;
 139+ text-align: left;
 140+}
 141+
 142+.option-panel table {
 143+ width: 100%;
 144+}
 145+
 146+.option-panel td.option-field {
 147+ width: 100%;
 148+ padding-top: 1px;
 149+ padding-bottom: 1px;
 150+}
 151+
 152+.option-panel th {
 153+ vertical-align: top;
 154+}
\ No newline at end of file
Property changes on: trunk/extensions/Wikidata/OmegaWiki/tables.css
___________________________________________________________________
Added: svn:eol-style
1155 + native
Index: trunk/extensions/Wikidata/OmegaWiki/suggest.css
——@@ -0,0 +1,94 @@
 2+/*
 3+ Copy
 4+ @import url("../../extensions/Wikidata/WiktionaryZ/tmp/suggest.css");
 5+
 6+ into the appropriate stylesheets like
 7+ skins/monobook/main.css
 8+ skins/common/common.css
 9+*/
 10+
 11+
 12+/* Suggestion control */
 13+
 14+.suggest-link {
 15+ padding-right: 22px;
 16+ padding-left: 2px;
 17+ cursor: pointer;
 18+ border-width: 1px;
 19+ border-style: solid;
 20+ border-color: #7F9DB9;
 21+
 22+ background-image: url("../../Images/ArrowButtonDown1px.png");
 23+ background-repeat: no-repeat;
 24+ background-position: center right;
 25+}
 26+
 27+.wiki-data-table td .suggest-link, .option-panel td .suggest-link {
 28+ display: block;
 29+ zoom: 1;
 30+ left: 0px;
 31+ right: 1px;
 32+ top: 1px;
 33+ bottom: 0px;
 34+ background-color: #FFFFFF;
 35+}
 36+
 37+/* Internet Explorer hack */
 38+* html .suggest-link {
 39+ background-image: url("../../Images/ArrowButtonDown2px.png");
 40+}
 41+
 42+/* Internet Explorer hack */
 43+* html .wiki-data-table td .suggest-link {
 44+ background-image: url("../../Images/ArrowButtonDown1px.png");
 45+}
 46+
 47+.suggest-drop-down {
 48+ /*font-size: 1em;*/
 49+ font-size: 13px;
 50+}
 51+
 52+.suggest-link, .suggest-link:hover, .suggest-link:active, .suggest-link:visited {
 53+ color: #000000;
 54+ text-decoration: none;
 55+ white-space: nowrap;
 56+}
 57+
 58+td .suggest-link, td .suggest-link:hover, td .suggest-link:active, td .suggest-link:visited {
 59+ white-space: normal;
 60+}
 61+
 62+.suggestion-row {
 63+ padding: 0px;
 64+ margin: 0px;
 65+}
 66+
 67+.suggestion-row.active td.column-even, .suggestion-row.active td.column-odd {
 68+ /*background-color: #DDDDDD;*/
 69+ background-color: #CECCF7;
 70+ cursor: pointer;
 71+}
 72+
 73+.suggestion-row td {
 74+ padding-top: 0px;
 75+ padding-bottom: 0px;
 76+ padding-left: 4px;
 77+ padding-right: 4px;
 78+ margin-top: 0px;
 79+ margin-bottom: 0px;
 80+ white-space: nowrap;
 81+}
 82+
 83+.suggest-loading {
 84+ background-color: #DDDDDD;
 85+}
 86+
 87+.suggest-next {
 88+ margin-left: 2px;
 89+ margin-right: 8px;
 90+}
 91+
 92+.suggest-previous {
 93+ margin-left: 8px;
 94+ margin-right: 2px;
 95+}
\ No newline at end of file
Property changes on: trunk/extensions/Wikidata/OmegaWiki/suggest.css
___________________________________________________________________
Added: svn:eol-style
196 + native
Index: trunk/extensions/Wikidata/README
——@@ -5,6 +5,7 @@
66 Database scripts/
77 /Convenience - useful scripts for developers
88 /Incremental - necessary update scripts to keep your extension installation in sync with the trunk
 9+Images/ - images used in the Wikidata UI
910 OmegaWiki/ - the current main (only) application of the Wikidata framework
1011 perl-tools/ - import/export tools written in Perl
1112 php-tools/ - import/export tools written in PHP