r19766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19765‎ | r19766 | r19767 >
Date:18:42, 4 February 2007
Author:brion
Status:old
Tags:
Comment:
Cleanup from r19742:
* use diffchange class alone for backwards compatibility with old renderings and diff plugins
* set text-decoration: none in diffs in RSS/Atom feeds
* fix bad diff regex in UTF-8 RandomTest script
Modified paths:
  • /trunk/phase3/includes/SpecialRecentchanges.php (modified) (history)
  • /trunk/phase3/includes/normal/RandomTest.php (modified) (history)
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/common/common.css (modified) (history)
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)
  • /trunk/phase3/skins/monobook/handheld.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/simple/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
@@ -415,8 +415,7 @@
416416 background:#eeeeee;
417417 font-size: smaller;
418418 }
419 -ins.diffchange { color: red; text-decoration: none; }
420 -del.diffchange { color: red; text-decoration: none; }
 419+.diffchange { color: red; text-decoration: none; }
421420
422421 a.external { color: #3366bb; }
423422
Index: trunk/phase3/skins/monobook/handheld.css
@@ -559,7 +559,7 @@
560560 background: #eee;
561561 font-size: smaller;
562562 }
563 -span.diffchange {
 563+.diffchange {
564564 color: red;
565565 font-weight: bold;
566566 }
Index: trunk/phase3/skins/monobook/main.css
@@ -591,16 +591,11 @@
592592 background: #eee;
593593 font-size: smaller;
594594 }
595 -ins.diffchange {
 595+.diffchange {
596596 color: red;
597597 font-weight: bold;
598598 text-decoration: none;
599599 }
600 -del.diffchange {
601 - color: red;
602 - font-weight: bold;
603 - text-decoration: none;
604 -}
605600
606601 /*
607602 ** keep the whitespace in front of the ^=, hides rule from konqueror
Index: trunk/phase3/skins/common/common.css
@@ -125,16 +125,11 @@
126126 background:#eeeeee;
127127 font-size: 94%;
128128 }
129 -ins.diffchange {
 129+.diffchange {
130130 color: red;
131131 font-weight: bold;
132132 text-decoration: none;
133133 }
134 -del.diffchange {
135 - color: red;
136 - font-weight: bold;
137 - text-decoration: none;
138 -}
139134
140135 img { border: none; }
141136 img.tex { vertical-align: middle; }
Index: trunk/phase3/skins/common/commonPrint.css
@@ -283,13 +283,8 @@
284284 background:#eeeeee;
285285 font-size: smaller;
286286 }
287 -ins.diffchange {
 287+.diffchange {
288288 color: silver;
289289 font-weight: bold;
290290 text-decoration: underline;
291291 }
292 -del.diffchange {
293 - color: silver;
294 - font-weight: bold;
295 - text-decoration: underline;
296 -}
Index: trunk/phase3/skins/simple/main.css
@@ -268,8 +268,7 @@
269269 background-color: #f8ffaa;
270270 }
271271
272 -ins.diffchange { background-color: #FFCDF3; text-decoration: none; }
273 -del.diffchange { background-color: #FFCDF3; text-decoration: none; }
 272+.diffchange { background-color: #FFCDF3; text-decoration: none; }
274273 .autocomment { color: grey; }
275274 #pagehistory span.user {
276275 margin-left: 1.4em;
Index: trunk/phase3/includes/SpecialRecentchanges.php
@@ -691,7 +691,7 @@
692692 'diff-addedline' => 'background: #cfc; font-size: smaller;',
693693 'diff-deletedline' => 'background: #ffa; font-size: smaller;',
694694 'diff-context' => 'background: #eee; font-size: smaller;',
695 - 'diffchange' => 'color: red; font-weight: bold;',
 695+ 'diffchange' => 'color: red; font-weight: bold; text-decoration: none;',
696696 );
697697
698698 foreach( $styles as $class => $style ) {
Index: trunk/phase3/includes/normal/RandomTest.php
@@ -69,7 +69,7 @@
7070 $formatter = new TableDiffFormatter();
7171 $funky = $formatter->format( $diffs );
7272 $matches = array();
73 - preg_match_all( '/<(?:ins|del) class="diffchange">(.*?)<\/span>/', $funky, $matches );
 73+ preg_match_all( '/<(?:ins|del) class="diffchange">(.*?)<\/(?:ins|del)>/', $funky, $matches );
7474 foreach( $matches[1] as $bit ) {
7575 $hex = bin2hex( $bit );
7676 echo "\t$hex\n";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r19742Fix #6844: Semantically correct tags for diffchanges (<ins> && <del>)...hashar21:47, 3 February 2007