r19744 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19743‎ | r19744 | r19745 >
Date:21:58, 3 February 2007
Author:hashar
Status:old
Tags:
Comment:
Fix #6684: Improper javascript array iteration causes problems
Patch by Dan Li <dto@dev.java.net>
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -374,10 +374,10 @@
375375 return false;
376376 }
377377
378 - for (var i in mwEditButtons) {
 378+ for (var i = 0; i < mwEditButtons.length; i++) {
379379 mwInsertEditButton(toolbar, mwEditButtons[i]);
380380 }
381 - for (i in mwCustomEditButtons) {
 381+ for (var i = 0; i < mwCustomEditButtons.length; i++) {
382382 mwInsertEditButton(toolbar, mwCustomEditButtons[i]);
383383 }
384384 return true;
Index: trunk/phase3/RELEASE-NOTES
@@ -169,6 +169,7 @@
170170 * Fix for paths in 1.4->1.5 special-case updater script
171171 * (bug 8789) AJAX search: IE users can now use the return key
172172 * (bug 6844) Use <ins> and <del> tags to emphase the differences
 173+* (bug 6684) Fix improper javascript array iteration
173174
174175
175176 == Languages updated ==