r19736 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r19735‎ | r19736 | r19737 >
Date:06:52, 3 February 2007
Author:gszorc
Status:old
Tags:
Comment:
Removed optional '?>' from end of generated config file
This will prevent people with poor editors (Windows) from accidentally introducing blank lines after the '?>', which we all know breaks XML output
Modified paths:
  • /trunk/phase3/config/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/index.php
——@@ -912,7 +912,7 @@
913913 /* Write out the config file now that all is well */
914914 print "<li style=\"list-style: none\">\n";
915915 print "<p>Creating LocalSettings.php...</p>\n\n";
916 - $localSettings = "<" . "?php$endl$local$endl?" . ">\r\n";
 916+ $localSettings = "<" . "?php$endl$local$endl\r\n";
917917 // Fix up a common line-ending problem (due to CVS on Windows)
918918 $localSettings = str_replace( "\r\n", "\n", $localSettings );
919919 $f = fopen( "LocalSettings.php", 'xt' );

Status & tagging log