r19636 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19635‎ | r19636 | r19637 >
Date:17:19, 24 January 2007
Author:brion
Status:old
Tags:
Comment:
* (bug 8751) Set session cookies to HTTPS-only to match other cookies
patch from http://bugzilla.wikimedia.org/attachment.cgi?id=3132
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2062,7 +2062,7 @@
20632063 * Initialise php session
20642064 */
20652065 function wfSetupSession() {
2066 - global $wgSessionsInMemcached, $wgCookiePath, $wgCookieDomain;
 2066+ global $wgSessionsInMemcached, $wgCookiePath, $wgCookieDomain, $wgCookieSecure;
20672067 if( $wgSessionsInMemcached ) {
20682068 require_once( 'MemcachedSessions.php' );
20692069 } elseif( 'files' != ini_get( 'session.save_handler' ) ) {
@@ -2070,7 +2070,7 @@
20712071 # application, it will end up failing. Try to recover.
20722072 ini_set ( 'session.save_handler', 'files' );
20732073 }
2074 - session_set_cookie_params( 0, $wgCookiePath, $wgCookieDomain );
 2074+ session_set_cookie_params( 0, $wgCookiePath, $wgCookieDomain, $wgCookieSecure);
20752075 session_cache_limiter( 'private, must-revalidate' );
20762076 @session_start();
20772077 }
Index: trunk/phase3/RELEASE-NOTES
@@ -145,6 +145,7 @@
146146 red when the user has no edits. Linker::userToolLinksRedContribs() is an
147147 alias to that which should be used to make it more self documentating.
148148 * (bug 8749) Bring MySQL 5 table defs back into sync
 149+* (bug 8751) Set session cookies to HTTPS-only to match other cookies
149150
150151
151152 == Languages updated ==