r19449 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19448‎ | r19449 | r19450 >
Date:13:36, 18 January 2007
Author:robchurch
Status:old
Tags:
Comment:
(bug 8688) Handle underscores/spaces in Special:Blockip and Special:Ipblocklist in a consistent manner
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialBlockip.php (modified) (history)
  • /trunk/phase3/includes/SpecialIpblocklist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialBlockip.php
@@ -43,6 +43,7 @@
4444 global $wgRequest;
4545
4646 $this->BlockAddress = $wgRequest->getVal( 'wpBlockAddress', $wgRequest->getVal( 'ip', $par ) );
 47+ $this->BlockAddress = strtr( $this->BlockAddress, '_', ' ' );
4748 $this->BlockReason = $wgRequest->getText( 'wpBlockReason' );
4849 $this->BlockExpiry = $wgRequest->getVal( 'wpBlockExpiry', wfMsg('ipbotheroption') );
4950 $this->BlockOther = $wgRequest->getVal( 'wpBlockOther', '' );
Index: trunk/phase3/includes/SpecialIpblocklist.php
@@ -44,7 +44,7 @@
4545 var $ip, $reason, $id;
4646
4747 function IPUnblockForm( $ip, $id, $reason ) {
48 - $this->ip = $ip;
 48+ $this->ip = strtr( $ip, '_', ' ' );
4949 $this->id = $id;
5050 $this->reason = $reason;
5151 }
Index: trunk/phase3/RELEASE-NOTES
@@ -119,6 +119,8 @@
120120 * (bug 8673) Minor fix for web service API content-type header
121121 * Fix API revision list on PHP 5.2.1; bad reference assignment
122122 * (bug 8136) Introduce 'ArticleUndelete' hook; see docs/hooks.txt for more info
 123+* (bug 8688) Handle underscores/spaces in Special:Blockip and Special:Ipblocklist
 124+ in a consistent manner
123125
124126 == Languages updated ==
125127