r19084 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r19083‎ | r19084 | r19085 >
Date:19:13, 10 January 2007
Author:ivanlanin
Status:old
Tags:
Comment:
Fix SpecialVersion->formatCredits input. Version and Url parameters should be null to be treated properly with isset.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialVersion.php
@@ -118,9 +118,9 @@
119119 foreach ( $wgExtensionCredits[$type] as $extension ) {
120120 $out .= $this->formatCredits(
121121 isset ( $extension['name'] ) ? $extension['name'] : '',
122 - isset ( $extension['version'] ) ? $extension['version'] : '',
 122+ isset ( $extension['version'] ) ? $extension['version'] : null,
123123 isset ( $extension['author'] ) ? $extension['author'] : '',
124 - isset ( $extension['url'] ) ? $extension['url'] : '',
 124+ isset ( $extension['url'] ) ? $extension['url'] : null,
125125 isset ( $extension['description'] ) ? $extension['description'] : ''
126126 );
127127 }
@@ -193,7 +193,7 @@
194194
195195 foreach ($myWgHooks as $hook => $hooks)
196196 $ret .= "<tr><td>$hook</td><td>" . $this->listToText( $hooks ) . "</td></tr>\n";
197 -
 197+
198198 $ret .= '</table>';
199199 return $ret;
200200 } else
Index: trunk/phase3/RELEASE-NOTES
@@ -37,6 +37,8 @@
3838 * (bugs 5051, 5376) Tooltips and accesskeys no longer require JavaScript
3939 * Added SkinTemplateOutputPageBeforeExec hook before SkinTemplate::outputPage()
4040 starts page output (http://lists.wikimedia.org/pipermail/wikitech-l/2007-January/028554.html)
 41+* Fix SpecialVersion->formatCredits input. Version and Url parameters should be null
 42+ to be treated properly with isset.
4143
4244 == Languages updated ==
4345