r18980 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r18979‎ | r18980 | r18981 >
Date:22:07, 8 January 2007
Author:tstarling
Status:old
Tags:
Comment:
Remove line breaks from query.
Modified paths:
  • /trunk/phase3/includes/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialContributions.php
@@ -158,13 +158,13 @@
159159
160160 $nscond = $this->getNamespaceCond();
161161 $use_index = $this->dbr->useIndexClause( $index );
162 - $sql = "SELECT
163 - page_namespace,page_title,page_is_new,page_latest,
164 - rev_id,rev_page,rev_text_id,rev_timestamp,rev_comment,rev_minor_edit,rev_user,rev_user_text,
165 - rev_deleted
166 - FROM $page,$revision $use_index
167 - WHERE page_id=rev_page AND $userCond $nscond $offsetQuery
168 - ORDER BY rev_timestamp DESC";
 162+ $sql = 'SELECT ' .
 163+ 'page_namespace,page_title,page_is_new,page_latest,'.
 164+ 'rev_id,rev_page,rev_text_id,rev_timestamp,rev_comment,rev_minor_edit,rev_user,rev_user_text,'.
 165+ 'rev_deleted ' .
 166+ "FROM $page,$revision $use_index " .
 167+ "WHERE page_id=rev_page AND $userCond $nscond $offsetQuery " .
 168+ 'ORDER BY rev_timestamp DESC';
169169 $sql = $this->dbr->limitResult( $sql, $this->limit, 0 );
170170 return $sql;
171171 }