r18950 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r18949‎ | r18950 | r18951 >
Date:09:45, 8 January 2007
Author:brion
Status:old
Tags:
Comment:
Restore previous heading formatting behavior to fix 12 parser tests broken by r18948, which claimed it wasn't supposed to impact output. :)
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1070,7 +1070,7 @@
10711071 * @return string HTML headline
10721072 */
10731073 public function makeHeadline( $level, $attribs, $anchor, $text, $link ) {
1074 - return "<a name=\"$anchor\" id=\"$anchor\"></a> <h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
 1074+ return "<a name=\"$anchor\"></a><h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
10751075 }
10761076
10771077 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r18948* Move headline construction to Linker function (from being hardcoded in Parser)...simetrical02:11, 8 January 2007