r18947 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r18946‎ | r18947 | r18948 >
Date:01:41, 8 January 2007
Author:brion
Status:ok
Tags:
Comment:
Revert r18893/18894 (Special:Listinterwikis) for the moment; pretty broken.
- no html escaping
- ugly :)
- doesn't use alternate interwiki database so will be wrong on wikimedia sites
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialListinterwikis.php (deleted) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFr.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialListinterwikis.php
@@ -1,42 +0,0 @@
2 -<?php
3 -/**
4 - * @package MediaWiki
5 - * @subpackage SpecialPage
6 - *
7 - * @author Ashar Voultoiz <hashar@altern.org>
8 - * @licence GNU General Public Licence 2.0 or later
9 - *
10 - */
11 -
12 -class ListinterwikisPage extends QueryPage {
13 -
14 - function getName() { return( 'Listinterwikis' ); }
15 - function isExpensive() { return false; }
16 - function isSyndicated() { return false; }
17 - function sortDescending() { return false; }
18 -
19 - /**
20 - * We have a little fun with title, namespace but its required by QueryPage.
21 - */
22 - function getSQL() {
23 - $dbr =& wfGetDB( DB_SLAVE );
24 - $iw = $dbr->tableName( 'interwiki' );
25 - $sql = "SELECT 'Listinterwikis' AS type, iw_url AS title, 0 AS namespace, iw_prefix AS value, iw_local, iw_trans FROM $iw";
26 - return $sql;
27 - }
28 -
29 - function formatResult( $skin, $result ) {
30 - return
31 - $result->value
32 - . ' ... '
33 - . $skin->makeExternalLink($result->title, $result->title);
34 - }
35 -}
36 -
37 -function wfSpecialListinterwikis() {
38 - list( $limit, $offset ) = wfCheckLimits();
39 - $lip = new ListinterwikisPage();
40 - $lip->doQuery( $offset, $limit );
41 -}
42 -?>
43 -
Index: trunk/phase3/includes/SpecialPage.php
@@ -135,7 +135,6 @@
136136 'MIMEsearch' => array( 'SpecialPage', 'MIMEsearch' ),
137137 'Unwatchedpages' => array( 'SpecialPage', 'Unwatchedpages', 'unwatchedpages' ),
138138 'Listredirects' => array( 'SpecialPage', 'Listredirects' ),
139 - 'Listinterwikis' => array( 'SpecialPage', 'Listinterwikis' ),
140139 'Revisiondelete' => array( 'SpecialPage', 'Revisiondelete', 'deleterevision' ),
141140 'Unusedtemplates' => array( 'SpecialPage', 'Unusedtemplates' ),
142141 'Randomredirect' => array( 'SpecialPage', 'Randomredirect' ),
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1408,9 +1408,6 @@
14091409 'unwatchedpages' => 'Unwatched pages',
14101410 'unwatchedpages-summary' => '',
14111411
1412 -# List interwikis
1413 -'listinterwikis' => 'List interwikis',
1414 -
14151412 # List redirects
14161413 'listredirects' => 'List redirects',
14171414 'listredirects-summary' => '',
Index: trunk/phase3/languages/messages/MessagesFr.php
@@ -772,9 +772,6 @@
773773 #
774774 'unwatchedpages' => 'Pages non suivies',
775775
776 -# List interwikis
777 -'listinterwikis' => 'Liste des interwikis',
778 -
779776 # List redirects
780777 'listredirects' => 'Liste des redirections',
781778
Index: trunk/phase3/RELEASE-NOTES
@@ -473,7 +473,6 @@
474474 * (bug 8417) Handle EXIF unknown dates
475475 * (bug 8372) Return nothing on empty <math> tags.
476476 * New maintenance script to show the cached statistics : showStats.php.
477 -* New special page to list available interwikis [[Special:Listinterwikis]]
478477 * Count deleted edits when regenerating total edits in maintenance/initStats.php
479478 * (bug 3706) Allow users to be exempted from IP blocks. The ipblock-exempt permission
480479 key has been added to enable this behaviour, by default assigned to sysops.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r18893Special:Listinterwikishashar23:42, 6 January 2007

Status & tagging log