r18891 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r18890‎ | r18891 | r18892 >
Date:23:19, 6 January 2007
Author:simetrical
Status:old
Tags:
Comment:
Roll back workaround for Firefox link underlining: I realized that <u><u>Foo</u></u> is not necessarily supposed to display the same as <u>Foo</u>, so there will be double-underlining or similar bad stuff in some cases. Mozilla has to fix this one.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -460,7 +460,7 @@
461461 $s = '';
462462 if (($undopt = $wgUser->getOption("underline")) != 2) {
463463 $underline = $undopt ? 'underline' : 'none';
464 - $s .= "a, a * { text-decoration: $underline; }\n";
 464+ $s .= "a { text-decoration: $underline; }\n";
465465 }
466466 if( $wgUser->getOption( 'highlightbroken' ) ) {
467467 $s .= "a.new, #quickbar a.new { color: #CC2200; }\n";
Index: trunk/phase3/RELEASE-NOTES
@@ -462,10 +462,8 @@
463463 * (bug 8330) Show "bytes" suffix on recent changes diff counter
464464 * (bug 8489) Support basic links in <gallery> caption attribute
465465 * (bug 8485) Correct Lingala number formatting
466 -* When links are underlined, the entire link text should be underlined, even
467 - if it contains elements with a background color set.
468 -* The MediaWiki namespace is no longer pre-filled with default messages on
469 - install. All default messages will be removed from the MediaWiki namespace
 466+* The MediaWiki namespace is no longer pre-filled with default messages on
 467+ install. All default messages will be removed from the MediaWiki namespace
470468 on upgrade.
471469 * Recentchanges RSS/Atom feeds now use a separate message for the description
472470 to avoid cluttering it with useless wiki formatting