r18438 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r18437‎ \| r18438 \| r18439 >
Date:	05:35, 19 December 2006
Author:	nickj
Status:	old
Tags:
Comment:	* prevent minor W3C validator/tidy error on Special:Booksources about nesting of "</form>" tag by swapping the order of two lines. * stop minor tidy warning: "<input> attribute 'size' lacks value", by setting size to 20 (which allows enough visual field width for 10 ISBN digits + some leeway for extra dashes and spaces and whatnot).
Modified paths:	/trunk/phase3/includes/SpecialBooksources.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialBooksources.php
—	—	@@ -58,10 +58,10 @@
59	59	$form = '<fieldset><legend>' . wfMsgHtml( 'booksources-search-legend' ) . '</legend>';
60	60	$form .= Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) );
61	61	$form .= Xml::hidden( 'title', $title->getPrefixedText() );
62		~~- $form .= '<p>' . Xml::inputLabel( wfMsg( 'booksources-isbn' ), 'isbn', 'isbn', false, $this->isbn );~~
	62	+ $form .= '<p>' . Xml::inputLabel( wfMsg( 'booksources-isbn' ), 'isbn', 'isbn', 20, $this->isbn );
63	63	$form .= ' ' . Xml::submitButton( wfMsg( 'booksources-go' ) ) . '</p>';
	64	+ $form .= Xml::closeElement( 'form' );
64	65	$form .= '</fieldset>';
65		~~- $form .= Xml::closeElement( 'form' );~~
66	66	return $form;
67	67	}
68	68