r17915 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r17914‎ | r17915 | r17916 >
Date:22:10, 24 November 2006
Author:brion
Status:old
Tags:
Comment:
* Installer support for experimental MySQL 4.1/5.0 binary-safe schema
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/config/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/index.php
@@ -532,9 +532,10 @@
533533 $conf->RootPW = importPost( "RootPW", "-" );
534534
535535 ## MySQL specific:
536 - $conf->DBprefix = importPost( "DBprefix" );
537 - $conf->DBmysql5 = (importPost( "DBmysql5" ) == "true") ? "true" : "false";
538 - $conf->LanguageCode = importPost( "LanguageCode", "en" );
 536+ $conf->DBprefix = importPost( "DBprefix" );
 537+ $conf->DBschema = importPost( "DBschema", "mysql4" );
 538+ $conf->DBmysql5 = ($conf->DBschema == "mysql5" || $conf->DBschema == "mysql5-binary");
 539+ $conf->LanguageCode = importPost( "LanguageCode", "en" );
539540
540541 ## Postgres specific:
541542 $conf->DBport = importPost( "DBport", "5432" );
@@ -836,12 +837,21 @@
837838 # FIXME: Check for errors
838839 print "<li>Creating tables...";
839840 if ($conf->DBtype == 'mysql') {
840 - if( $wgDBmysql5 ) {
841 - print " using MySQL 5 table defs...";
842 - dbsource( "../maintenance/mysql5/tables.sql", $wgDatabase );
843 - } else {
 841+ switch( $conf->DBschema ) {
 842+ case "mysql4":
844843 print " using MySQL 4 table defs...";
845844 dbsource( "../maintenance/tables.sql", $wgDatabase );
 845+ break;
 846+ case "mysql5":
 847+ print " using MySQL 5 UTF-8 table defs...";
 848+ dbsource( "../maintenance/mysql5/tables.sql", $wgDatabase );
 849+ break;
 850+ case "mysql5-binary":
 851+ print " using MySQL 5 binary table defs...";
 852+ dbsource( "../maintenance/mysql5/tables-binary.sql", $wgDatabase );
 853+ break;
 854+ default:
 855+ dieout( " <b>invalid schema selection!</b></li>" );
846856 }
847857 dbsource( "../maintenance/interwiki.sql", $wgDatabase );
848858 } else if ($conf->DBtype == 'postgres') {
@@ -1198,8 +1208,9 @@
11991209 <div class="config-input"><label class="column">Database charset</label>
12001210 <div>Select one:</div>
12011211 <ul class="plain">
1202 - <li><?php aField( $conf, "DBmysql5", "Backwards-compatible UTF-8", "radio", "false" ); ?></li>
1203 - <li><?php aField( $conf, "DBmysql5", "Experimental MySQL 4.1/5.0 UTF-8", "radio", "true" ); ?></li>
 1212+ <li><?php aField( $conf, "DBschema", "Backwards-compatible UTF-8", "radio", "mysql4" ); ?></li>
 1213+ <li><?php aField( $conf, "DBschema", "Experimental MySQL 4.1/5.0 UTF-8", "radio", "mysql5" ); ?></li>
 1214+ <li><?php aField( $conf, "DBschema", "Experimental MySQL 4.1/5.0 binary", "radio", "mysql5-binary" ); ?></li>
12041215 </ul>
12051216 </div>
12061217 <p class="config-desc">
Index: trunk/phase3/RELEASE-NOTES
@@ -214,7 +214,9 @@
215215 in the autoblock_whitelist system message.
216216 * Added placeholders for text injection by hooks to EditPage.php
217217 * (bug 8009) Automatic edit summary for redirects is not filled for edits in existing pages
 218+* Installer support for experimental MySQL 4.1/5.0 binary-safe schema
218219
 220+
219221 == Languages updated ==
220222
221223 * Bishnupriya Manipuri (bpy)