r17867 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r17866‎ | r17867 | r17868 >
Date:23:32, 22 November 2006
Author:simetrical
Status:old
Tags:
Comment:
More bugs! Why did I only spot these after commit >:|
Modified paths:
  • /trunk/phase3/includes/Block.php (modified) (history)
  • /trunk/phase3/includes/IP.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Block.php
@@ -504,8 +504,8 @@
505505 wfDebug("Checking $wlEntry\n");
506506
507507 # Is the IP in this range?
508 - if (IP::isAddressInRange( $autoblockip, $wlEntry )) {
509 - wfDebug("IP $autoblockip matches $wlEntry, not autoblocking\n");
 508+ if (IP::isAddressInRange( $ip, $wlEntry )) {
 509+ wfDebug("IP $ip matches $wlEntry, not autoblocking\n");
510510 return true; #This /SHOULD/ introduce a dummy block - but
511511 # I don't know a safe way to do so. -werdna
512512 }
Index: trunk/phase3/includes/IP.php
@@ -218,8 +218,8 @@
219219 }
220220
221221 /**
222 - * Determine if a given integer IPv4 address is in a given range
223 - * @param int $addr
 222+ * Determine if a given IPv4 address is in a given range
 223+ * @param string $addr Dotted quad
224224 * @param string $range (CIDR, hyphenated dotted-quad, or single dotted-quad)
225225 * @return bool Whether or not the given address is in the given range. Returns false on error.
226226 */