r17724 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r17723‎ | r17724 | r17725 >
Date:16:49, 16 November 2006
Author:tstarling
Status:old
Tags:
Comment:
Removed broken redundant fallback to the Language message array. Message arrays are now merged pre-cache. It's a static call on a non-static function, it actually calls back to $wgMessageCache->load(), destroying the per-process message cache on every cache miss.
Modified paths:
  • /trunk/phase3/includes/MessageCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/MessageCache.php
——@@ -458,16 +458,6 @@
459459 }
460460 }
461461
462 - # Try the English array
463 - if( $message === false && $langcode != 'en' ) {
464 - wfSuppressWarnings();
465 - $message = Language::getMessage( $key );
466 - wfRestoreWarnings();
467 - if ( is_null( $message ) ) {
468 - $message = false;
469 - }
470 - }
471 -
472462 # Try the array of another language
473463 if( $message === false && strpos( $key, '/' ) ) {
474464 $message = explode( '/', $key );