r17607 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r17606‎ | r17607 | r17608 >
Date:09:33, 13 November 2006
Author:nickj
Status:old
Tags:
Comment:
* Sync parserTests expected image results with r17524.
* On further consideration, the current "HTML Hex character encoding" behaviour is fine, and there's no real reason to convert HTML Hex encodings to ASCII.
* However the handling of "|" chars in external URLs in image comments will leave an unmatched </a> tag.
Modified paths:
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
——@@ -4621,7 +4621,7 @@
46224622 !!input
46234623 [[Image:foobar.jpg|thumbnail= ]]
46244624 !!result
4625 -<div class="thumb tright"><div style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title=""><img src="http://example.com/images/3/3a/Foobar.jpg" alt="" width="180" height="-1" longdesc="/wiki/Image:Foobar.jpg" /></a> <div class="thumbcaption"><div class="magnify" style="float:right"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="Enlarge" /></a></div></div></div></div>
 4625+<div class="thumb tright"><div style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title=""><img src="http://example.com/images/3/3a/Foobar.jpg" alt="" width="180" height="20" longdesc="/wiki/Image:Foobar.jpg" /></a> <div class="thumbcaption"><div class="magnify" style="float:right"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="Enlarge" /></a></div></div></div></div>
46264626
46274627 !!end
46284628
——@@ -5732,11 +5732,11 @@
57335733 !! end
57345734
57355735 !! test
5736 -TODO: HTML Hex character encoding.
 5736+HTML Hex character encoding (spells the word "JavaScript")
57375737 !! input
57385738 &#x4A;&#x061;&#x0076;&#x00061;&#x000053;&#x0000063;&#114;&#x0000069;&#00000112;&#x0000000074;
57395739 !! result
5740 -<p>JavaScript
 5740+<p>&#x4a;&#x61;&#x76;&#x61;&#x53;&#x63;&#114;&#x69;&#112;&#x74;
57415741 </p>
57425742 !! end
57435743
——@@ -5860,6 +5860,18 @@
58615861
58625862 !!end
58635863
 5864+
 5865+# Images with the "|" character in external URLs in comment tags; Eats half the comment, leaves unmatched "</a>" tag.
 5866+!! test
 5867+TODO: Images with the "|" character in the comment
 5868+!! input
 5869+[[image:Foobar.jpg|thumb|An [http://test/?param1=|left|&param2=|x external] URL]]
 5870+!! result
 5871+<div class="thumb tright"><div style="width:182px;"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="An external URL"><img src="http://example.com/images/thumb/3/3a/Foobar.jpg/180px-Foobar.jpg" alt="An external URL" width="180" height="20" longdesc="/wiki/Image:Foobar.jpg" /></a> <div class="thumbcaption"><div class="magnify" style="float:right"><a href="https://www.mediawiki.org/wiki/Image:Foobar.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="Enlarge" /></a></div>An <a href="http://test/?param1=|left|&amp;param2=|x" class="external text" title="http://test/?param1=|left|&amp;param2=|x" rel="nofollow">external</a> URL</div></div></div>
 5872+
 5873+!!end
 5874+
 5875+
58645876 #
58655877 #
58665878 #

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r17524* Approximate height for client-side scaling fallback instead of passing -1 i...brion13:23, 10 November 2006